Skip navigation
Currently Being Moderated

Cfsettting twice- ok or wasteful?

May 25, 2012 7:38 AM

I have an update query and an add query that are used according to a condition. They both have the same cfset values. Can I just put the cfset tags outside the cfif blocks and get rid of the duplicate code? (the example below has two cfset tags, in reality I have about 30 in each so it is a lot of duplication) Thank you

 

<!--- UPDATE QUERY --->
<cfif isDefined("form.UPDATEADDBTN")>
<cfif FORM.ENTID GTE 1>
<cfset isCOMPANYNull = iif(len(trim(form.COMPANY)) EQ 0, true, false)>
<cfset isSTATE1Null = iif(len(trim(form.STATE1)) EQ 0, true, false)>

<CFQUERY name="updatecompany" datasource="salesdb">
update COMPANY
SET COMPANY = <cfqueryparam cfsqltype="cf_sql_longvarchar" value="#trim(form.COMPANY)#" null="#isCOMPANYNull#" />,
   STATE1= <cfqueryparam cfsqltype="cf_sql_integer" value="#trim(form.STATE1)#" null="#isSTATE1Null#" />
WHERE ENTID = #FORM.ENTID#
</CFQUERY>
<CFLOCATION URL="member_welcome.cfm?begin=1">
<cfelse>
<cfset isCOMPANYNull = iif(len(trim(form.COMPANY)) EQ 0, true, false)>
<cfset isSTATE1Null = iif(len(trim(form.STATE1)) EQ 0, true, false)>

<!--- ADD COMPANY QUERY --->
<CFQUERY name="addcompany" datasource="salesdb">
INSERT INTO COMPANY(
COMPANY,
STATE1

VALUES (
<cfqueryparam cfsqltype="cf_sql_longvarchar" value="#trim(form.COMPANY)#" null="#isCOMPANYNull#" />,
<cfqueryparam cfsqltype="cf_sql_integer" value="#trim(form.STATE1)#" null="#isSTATE1Null#" />
)
</CFQUERY>
<CFLOCATION URL="member_welcome.cfm?begin=1">
</cfif>
</cfif>

 
Replies

More Like This

  • Retrieving data ...

Bookmarked By (0)

Answers + Points = Status

  • 10 points awarded for Correct Answers
  • 5 points awarded for Helpful Answers
  • 10,000+ points
  • 1,001-10,000 points
  • 501-1,000 points
  • 5-500 points