Skip navigation
goodychurro1
goodychurro1
Currently Being Moderated

cfif variable is query values

Jun 24, 2012 7:25 PM

Hi all,

In the last section of the code I am testing to see if meetingdate is a holiday, what is the correct way to do it , am I on the right track? Thanks

 

<!--- QUERY TO GET HOLIDAY DATES --->
<CFQUERY name="hols" datasource="salesdb">
SELECT holiday, holidayid FROM holidays
</CFQUERY>

<!--- SET MEETINGDATE ACCORDING TO DAY OF THE WEEK --->
<cfset meetingDate = trim(form.meeting)>
<cfif not isDate(meetingDate)>
<cfif DayOfWeek(Now()) eq 2>
<cfset meetingDate = dateAdd("d", 2, now())>
<cfelseif DayOfWeek(Now()) eq 3>
<cfset meetingDate = dateAdd("d", 2, now())>
<cfelseif DayOfWeek(Now()) eq 4>
<cfset meetingDate = dateAdd("d", 2, now())>

 

</cfif>
</cfif>

 

<!--- NOW CHECK IF NEW MEETINGDATE IS A HOLIDAY AND ADD DAYS--->

<cfif meetingDate = hols.holiday >
<cfif meetingDate eq 2>
<cfset meetingDate = dateAdd("d", 3, now())>
<cfelseif meetingDate eq 3>
<cfset meetingDate = dateAdd("d", 3, now())>
<cfelseif meetingDate eq 4>
<cfset meetingDate = dateAdd("d", 2, now())>

 

</cfif>

750 Views   8 Replies   Latest reply: goodychurro1, Jun 27, 2012 1:27 PM
 
Replies
  • Dan Bracuk
    Currently Being Moderated
    1. Dan Bracuk,
    Jun 25, 2012 5:14 AM   in reply to goodychurro1
    Report

    You appear to be missing a function call in the bottom part of your code.  It also appears to be incomplete.  You don't have anything for Thursday and Friday.

     
    |
    Mark as:
  • goodychurro1
    Currently Being Moderated
    2. goodychurro1,
    Jun 25, 2012 8:22 AM   in reply to Dan Bracuk
    Report

    Hi Dan

    I got rid of  Thursday , Friday , Saturday and Sunday to make the code easier to read. What function call am I missing?

     
    |
    Mark as:
  • Dan Bracuk
    Currently Being Moderated
    3. Dan Bracuk,
    Jun 25, 2012 9:37 AM   in reply to goodychurro1
    Report

    If you want the code to be easier to read, consider using switch/case instead of if/else if/else. 

     
    |
    Mark as:
  • goodychurro1
    Currently Being Moderated
    4. goodychurro1,
    Jun 25, 2012 5:10 PM   in reply to Dan Bracuk
    Report

    Hi I'm going back to basics on this one, using a date that I know is in the hols query, then using listfind to see if it appears. I run the following code which should add 5 days to the meetingDate date as the 25th of December 2012 is a tuesday but it doesn't. Why not? Thanks

     

    <CFQUERY name="hols" datasource="salesdb">
    SELECT * FROM holidays
    </CFQUERY>

     

    <cfset meetingDate = '2012-12-25'>

     

    <cfif ListFind(ValueList(hols.holiday), meetingDate)>

     

    <cfif meetingDate eq 2>
    <cfset meetingDate = dateAdd("d", 2, now())>
    <cfelseif meetingDate eq 3>
    <cfset meetingDate = dateAdd("d", 5, now())>
    <cfelseif meetingDate eq 4>
    <cfset meetingDate = dateAdd("d", 2, now())>
    <cfelseif meetingDate eq 5>
    <cfset meetingDate = dateAdd("d", 4, now())>
    <cfelseif meetingDate eq 6>
    <cfset meetingDate = dateAdd("d", 3, now())>
    <cfelseif meetingDate eq 7>
    <cfset meetingDate = dateAdd("d", 2, now())>
    <cfelseif meetingDate eq 1>
    <cfset meetingDate = dateAdd("d", 1, now())>
    </cfif>


    </cfif>

    <cfdump var="#hols#"> 
    <cfoutput>#meetingDate#</cfoutput>

     
    |
    Mark as:
  • Dan Bracuk
    Currently Being Moderated
    5. Dan Bracuk,
    Jun 25, 2012 8:27 PM   in reply to goodychurro1
    Report

    Why not? 

     

    You are checking to see if '2012-12-25' is 2, 3, 4, 5, 6, 7, or 1,  Which one did you expect to return true?

     
    |
    Mark as:
  • goodychurro1
    Currently Being Moderated
    6. goodychurro1,
    Jun 26, 2012 5:51 AM   in reply to Dan Bracuk
    Report

    I expected this one to return true as 2012-12-25 is a tuesday:

     

    <cfelseif meetingDate eq 3>

    <cfset meetingDate = dateAdd("d", 5, now())>

     
    |
    Mark as:
  • goodychurro1
    Currently Being Moderated
    7. goodychurro1,
    Jun 26, 2012 5:54 AM   in reply to goodychurro1
    Report

    Ah sorry I forgot to check for day of the week! I'll try with this code and see!

    <cfelseif DayOfWeek(meetingDate) eq 3>

     
    |
    Mark as:
  • goodychurro1
    Currently Being Moderated
    8. goodychurro1,
    Jun 27, 2012 1:27 PM   in reply to goodychurro1
    Report

    worked it out, thanks for the help guys

     

    <CFQUERY name="hols" datasource="salesdb">
    SELECT * FROM holidays
    </CFQUERY>

     

    <cfset meetingDate = '2012-07-20'>

    <cfoutput>#meetingDate#<br>
    #DayOfWeek(meetingDate)#</cfoutput>

     

    <cfif ListFind(ValueList(hols.holiday), meetingDate)>

    <cfif DayOfWeek(meetingDate) eq 2>
    <cfset meetingDate = dateAdd("d", 2, meetingDate)>
    <cfelseif DayOfWeek(meetingDate) eq 3>
    <cfset meetingDate = dateAdd("d", 5, meetingDate)>
    <cfelseif DayOfWeek(meetingDate) eq 4>
    <cfset meetingDate = dateAdd("d", 2, meetingDate)>
    <cfelseif DayOfWeek(meetingDate) eq 5>
    <cfset meetingDate = dateAdd("d", 4, meetingDate)>
    <cfelseif DayOfWeek(meetingDate) eq 6>
    <cfset meetingDate = dateAdd("d", 3, meetingDate)>
    <cfelseif DayOfWeek(meetingDate) eq 7>
    <cfset meetingDate = dateAdd("d", 2, meetingDate)>
    <cfelseif DayOfWeek(meetingDate) eq 1>
    <cfset meetingDate = dateAdd("d", 1, meetingDate)>
    </cfif>


    </cfif>

    <cfdump var="#hols#"> 
    <cfoutput> #meetingdate# <br>
    #DayOfWeek(meetingDate)#</cfoutput>

     
    |
    Mark as:
Actions

More Like This

  • Retrieving data ...

Bookmarked By (0)

Answers + Points = Status

  • 10 points awarded for Correct Answers
  • 5 points awarded for Helpful Answers
  • 10,000+ points
  • 1,001-10,000 points
  • 501-1,000 points
  • 5-500 points