I'm pretty sure I have my LR4 settings correct, when I click edit in PSE10, PSE10 opens but no photo transfers over with it
What system are you using?
Please ensure that PSE Editor exe is chosen as external editing app as shown in this screenshot-
If this is correct, which type of file are you sending for edit? Does that file open in PSE Editor when opened ouotside of LR?