Require both drop downs to be equal

Report · Nov 09, 2011

Hi. I have 2 drop downs per row of data that are for PNR and BOM initials. I want each row with both of these drop downs to match when submitted. If they don't, an error pops up saying that they have to match if there's something chosen in each drop down. I also have another column to tell if the part is a Change or New Entry by populating it with a "C" or an "N". When the part is an "N", the PNR Initials can be chosen and the BOM initials can be blank and it will go through fine. If it's an "N" and the BOM Initials are chosen and the PNR Initials are blank, an error pops up saying that the PNR Initials have to be chosen.

When the part is a "C", there are no restrictions, other than if there are initials chosen in each drop down, they have to match. It doesn't matter if one or the other is left blank.

I almost have all this working with Javascript, except that when just an "N" is on the page and initials are chosen for each column that don't match, the error pops up, which is good, but then when I click ok, it goes through and inserts the initials into the database. Why is that?

I also have a problem when there are just "C" part numbers on the page, the javascript does not work at all. No errors stop the 2 drop down initials from being entered when they don't match. There has to be an "N" on the page for the code to work at all. When this javascript was first created, it was just for the "N" part numbers, but then we wanted all the rows to have the code for the initials matching each other, so I added this code to the existing code and I have these problems now. Should I have created another javascript? The only problem is the onsubmit says this: onsubmit="return verify();" So I can't name another javascript file with the same name, can I, or can I?

There's some code towards the bottom that says if the Change or New Entry column is an "N" or "C", to do some stuff. I have attached the whole page of code, so you can see exactly what I'm talking about. Can someone help me with this? Thanks.

Andy

</center>

</table>

SELECT *

From Users

where Engineer_Initials = yes and Initials <> '#cookie.UserInitials#'

Order by Initials

</CFQUERY>

SELECT ECID, Requested_By_Initials, EC_Completion_Initials, EC_Completion_Date, Flag_Comments, Comments, ItemID, ECID_SPEC, ECO_Start_Date, Date_Requested, Part_Number, Description, P_Drive_Docs, Release_Status, Validation_ItemID, Validation_ECID, Validation_Qty, Open_Jobs_Affected, CN_Entry, SW_Model_Only,

Approval_PNR.APVID as PNR_APVID,

Approval_BOM.APVID as BOM_APVID,

Approval_PNR.Approval_Initials as PNR_Initials,

Approval_BOM.Approval_Initials as BOM_Initials,

Approval_PNR.Doc_Rev as PNR_Rev,

Approval_BOM.Doc_Rev as BOM_Rev

FROM ((((ECO_Master LEFT JOIN ECO_Items ON ECO_Master.ECID = ECO_Items.ECID_SPEC)

LEFT JOIN Validation_Records ON ECO_Items.ItemID = Validation_Records.Validation_ItemID)

LEFT JOIN Approval as Approval_PNR ON (ECO_Items.ItemID = Approval_PNR.APV_ItemID AND Approval_PNR.Document_Type = 'PNR Req'))

LEFT JOIN Approval as Approval_BOM ON (ECO_Items.ItemID = Approval_BOM.APV_ItemID AND Approval_BOM.Document_Type = 'BOM Req'))

WHERE Requested_By_Initials = '#cookie.UserInitials#'

AND EC_Completion_Date Is Null

And SW_Model_Only = 0

And Doc_Changes_Only = 0

And ((Approval_PNR.Approval_Initials Is Not Null And Approval_PNR.Approval_Initials <> '' And (Approval_PNR.Doc_Rev Is Null Or Approval_PNR.Doc_Rev = '') And Approval_BOM.Approval_Initials Is Not Null And Approval_BOM.Approval_Initials <> '' And Approval_BOM.Doc_Rev Is Not Null And Approval_BOM.Doc_Rev <> '')

Or (Approval_PNR.Approval_Initials Is Not Null And Approval_PNR.Approval_Initials <> '' And (Approval_PNR.Doc_Rev Is Null Or Approval_PNR.Doc_Rev = ''))

Or (Approval_BOM.Approval_Initials Is Not Null And Approval_BOM.Approval_Initials <> '' And (Approval_BOM.Doc_Rev Is Null Or Approval_BOM.Doc_Rev = '') And Approval_PNR.Approval_Initials Is Not Null And Approval_PNR.Approval_Initials <> '' And Approval_PNR.Doc_Rev Is Not Null And Approval_PNR.Doc_Rev <> '')

Or (Approval_BOM.Approval_Initials Is Not Null And Approval_BOM.Approval_Initials <> '' And (Approval_BOM.Doc_Rev Is Null Or Approval_BOM.Doc_Rev = ''))

Or ((Approval_PNR.Approval_Initials Is Null or Approval_PNR.Approval_Initials = '') And Approval_PNR.Doc_Rev Is Null And (Approval_BOM.Approval_Initials Is Null or Approval_BOM.Approval_Initials = '') And Approval_BOM.Doc_Rev Is Null))

ORDER BY ECID ASC, ItemID ASC

</CFQUERY>

<head>

<title>Select Engineer for PNR/BOM Approvals</title>

function verify() {

var partNumber = '';

var ecoNumber = '';

var bom;

var bomValue='';

var pnr;

var pnrValue='';

var requiredArray = document.getElementById('PNR_Required_ID_List').value.split(",");

var allArray = document.getElementById('listofids').value.split(",");

var sameArray = document.getElementById('Same_Required_ID_List').value.split(",");

var allArrayInit = document.getElementById('listofids').value.split(",");

var error=false;

for(var i=0;i<requiredArray.length;i++) {

pnr = document.getElementById('PNR_Approval_Initials'+requiredArray);

bom = document.getElementById('BOM_Approval_Initials'+requiredArray);

pnrValue = pnr[pnr.selectedIndex].value;

bomValue = bom[bom.selectedIndex].value;

if(bomValue != '' && pnrValue == '') {

error=true;

ecoNumber = document.getElementById('ECID'+requiredArray).value;

partNumber = document.getElementById('Part_Number'+requiredArray).value;

alert("You must enter some PNR initials for ECO " + ecoNumber + " Part Number: " + partNumber);

}

if(bomValue != pnrValue && bomValue != '') {

error=true;

ecoNumber = document.getElementById('ECID'+requiredArray).value;

partNumber = document.getElementById('Part_Number'+requiredArray).value;

alert("PNR and BOM Initials must be the same for ECO " + ecoNumber + " Part Number: " + partNumber);

}

for(var i=0;i<allArray.length;i++) {

pnr = document.getElementById('PNR_Approval_Initials'+allArray);

bom = document.getElementById('BOM_Approval_Initials'+allArray);

pnrValue = pnr[pnr.selectedIndex].value;

bomValue = bom[bom.selectedIndex].value;

}

for(var i=0;i<sameArray.length;i++) {

pnr = document.getElementById('PNR_Approval_Initials'+sameArray);

bom = document.getElementById('BOM_Approval_Initials'+sameArray);

pnrValue = pnr[pnr.selectedIndex].value;

bomValue = bom[bom.selectedIndex].value;

if(bomValue != pnrValue && pnrValue != '' && bomValue != '') {

error=true;

ecoNumber = document.getElementById('ECID'+sameArray).value;

partNumber = document.getElementById('Part_Number'+sameArray).value;

alert("PNR and BOM Initials must be the same for ECO " + ecoNumber + " Part Number: " + partNumber);

}

for(var i=0;i<allArrayInit.length;i++) {

pnr = document.getElementById('PNR_Approval_Initials'+allArrayInit);

bom = document.getElementById('BOM_Approval_Initials'+allArrayInit);

pnrValue = pnr[pnr.selectedIndex].value;

bomValue = bom[bom.selectedIndex].value;

}

if(error) {

return false;

}

else {

return true;

}

</script>

<!--- This works above in the brackets, but not here on it's own after the Change Value code.

if(bomValue !== pnrValue) {

error=true;

ecoNumber = document.getElementById('ECID'+requiredArray).value;

partNumber = document.getElementById('Part_Number'+requiredArray).value;

alert("PNR and BOM Initials must be the same for ECO " + ecoNumber + " Part Number: " + partNumber);

} --->

</head>

<body>

<tr>

#cookie.UserInitials#- Select Engineer for PNR/BOM Approvals

</center>

</td>

</tr>

</table>

<tr>

<!--- <td><B>APVID - PNR</B> </td>

<td><B>APVID - BOM</B> </td> --->

<td><B>Part Number </B></td>

<td align="center"><B>Change or<br>new entry</B></td>

<td align="center"><B>PNR<br>Initials</B></td>

<td align="center"><B>BOM<br>Initials</B></td>

<td align="center"><B>Open Jobs Affected</B></td>

<td align="center"><B>Comments</B></td>

</tr>

<tr>

</td>

</tr>

</td></tr>

</cfif>

<tr>

<td>

<font size = "5" color=dd0000><strong>#Flag_Comments#</strong></font>

</cfif>

</td>

#ECID#

</cfif>

</td>

#Part_Number#

</cfif>

</td>

#CN_Entry#

</cfif>

</td>

<option value="">PNR Initials</option>

<option value="#Initials#" <cfif Initials EQ PNRInitials>selected</cfif>>#Initials#</option>

</cfif>

</cfloop>

</select>

</td>

#PNR_Rev#

</cfif>

</td>

<option value="">BOM Initials</option>

<option value="#Initials#" <cfif Initials EQ BOMInitials>selected</cfif>>#Initials#</option>

</cfif>

</cfloop>

</select>

</td>

#BOM_Rev#

</cfif>

</td>

<td>

</cfif>

</td>

<td>

<textarea name="Comments#ItemID#" cols="38" rows="2">#Trim(Comments)#</textarea>

</td>

</tr>

</cfif>

</cfif>

</cfloop>

<tr>

</td>

</tr>

</table>

</cfform>

</table>

</div>

</body>

</html>

</cfoutput>

Report · Nov 10, 2011

Hi Andy,

that is a LOT of code to ask someone to sift through. I'm not sure you're going to get a lot of folks who will have the time to go through the entire code line by line to find your glitch. In general, whenever a problem like this pops up, its a good idea to reduce the code down to a gist proof-of-concept to see if you can get your functionality working in a vacuum (so to speak) in order to make sure it works.

Based on your description (i.e. the error pops up, but it still lets you submit the form) it sounds like your validation is on the selection, but you don't have any validation on the submission of the form (e.g. the form's onSubmit() handler). Without that, there is nothing that tells the form NOT to submit - it is largely ignorant of any javascript alerts you might have thrown up associated with other page elements.

Hope that helps!

- Michael

Adobe Community

Require both drop downs to be equal