1 Correct answer
I should have added:
It should work as long as you provide the locale-independent form of the string.
Sometimes simply adding $ID/ in front of the English menu name does not work or is not enough.
Better look for the title string of a menu and check with:
app.findKeyStrings("menu-title-name");
for the "universal" form(s) of the string.
Regards,
Uwe
20
Replies
So we tried without doScript: http://robinfredericf.free.fr/misc/wadyms-paragraphstyle-trick_indd003a.zip
// indd002-MinimumVersion-2.jsx
#target "InDesign";
#targetengine reformatToAppliedStyle
reformatToAppliedStyle();
function reformatToAppliedStyle()
{
if(app.documents.length == 0){ return; } // Do we need an alert here? No.
if(app.selection.length != 1){ return; } // Do we need an alert here? No.
if(!app.selection[0].hasOwnProperty("baselineShift"))
{ alert("Error: No text selected."); return; }
if(app.selection[0].styleOverridden == false)
{ alert("Error: No style override detected."); return; }
var menuItem = app.menus.item("$ID/ParaStylePanelPopup").menuItems.item("$ID/Redefine Style");
if(menuItem.isValid == false)
{ alert("Error: menuItem Redefine Style cannot be found."); return; }
if(menuItem.enabled == false)
{ alert("Error: menuItem Redefine Style is not enabled."); return; }
var myStyle = app.activeDocument.selection[0].insertionPoints[0].appliedParagraphStyle;
/*
// [ No Paragraph Style ] used.
NOTE: The following if statement should never be executed
if [ No Paragraph Style ] is really used on selected text,
because "Redefine Style" is never enabled with [ No Paragraph Style ]
and we already have an error condition for that case.
Nevertheless:
You cannot duplicate [ No Paragraph Style ]
*/
if(myStyle.index == 0)
{ alert("Error: No custom paragraph style applied: [ No Paragraph Style ]"); return; }
// [ Basic Paragraph Style ] used.
// You can duplicate that style, but you cannot remove the original.
// You cannot rename the duplicate to that style.
if(myStyle.index == 1)
{ alert("Error: No custom paragraph style applied: [ Basic Paragraph Style ]"); return; }
// FWIW: Styles cannot be named with [ or ] in their names.
// [ and ] are restricted to the names of the base styles.
// Maybe there are other special characters that are not working?!
var myStyleName = myStyle.name;
var myStyleCopy = myStyle.duplicate();
menuItem.associatedMenuAction.invoke();
myStyle.remove(myStyleCopy);
myStyleCopy.name = myStyleName;
}
Result:
So it says:
JavaScript Ошибка! = JavaScript Error!
Номер ошибки = Error number: 45
Сообщение об ошибке = Error report: Object is invalid
Engine: reformatToAppliedStyle
Файл = File: C:\Users\Вадим\AppData\Roaming\Adobe\InDesign\Version 11.0
\ru_RU\Scripts\Scripts Panel\wadyms-paragraphstyle-trick_indd003a.jsxСтрока = Line: 20
Источник = Source: var menuItem = app.menus.item
("$ID/ParaStylePanelPopup").menuItems.item("$ID/Redefine Style");
Hi Frédéric,
I spent a couple of hours on this but now I think I know why Wadym encounters the problem.
This is a bug in Russian locale. (so far I tested it only in CC 2015: the same version as Wadym has).
I tried to reference the menu item by index -- in my copy it's 97 -- and it returned quite a strange result:
- The isValid property of menuItem is false, but menuItemIsValid is true despite the fact it references the same above mentioned property.
- The name and title are strange: contain inch marks which is not allowed here I guess.
- There are no other properties
var menuItem = app.menus.itemByName("$ID/ParaStylePanelPopup");
Doesn't return a valid reference:
In English locale everything is OK:
I tested it with some other locales -- Arabic, Chinese, Spanish, Polish -- and it works OK, so it happens only in Russian.
I suggest Wadym and everybody with Russian Indy not to use the menu item reference but use menuActions.itemByID instead.
Here's my version:
#target "InDesign";
#targetengine reformatToAppliedStyle
reformatToAppliedStyle();
function reformatToAppliedStyle() {
try {
if(app.documents.length == 0){ return; } // Do we need an alert here? No.
if(app.selection.length != 1){ return; } // Do we need an alert here? No.
if(!app.selection[0].hasOwnProperty("baselineShift"))
{ alert("Error: No text selected."); return; }
if(app.selection[0].styleOverridden == false)
{ alert("Error: No style override detected."); return; }
var myStyle = app.activeDocument.selection[0].insertionPoints[0].appliedParagraphStyle;
/*
// [ No Paragraph Style ] used.
NOTE: The following if statement should never be executed
if [ No Paragraph Style ] is really used on selected text,
because "Redefine Style" is never enabled with [ No Paragraph Style ]
and we already have an error condition for that case.
Nevertheless:
You cannot duplicate [ No Paragraph Style ]
*/
if(myStyle.index == 0)
{ alert("Error: No custom paragraph style applied: [ No Paragraph Style ]"); return; }
// [ Basic Paragraph Style ] used.
// You can duplicate that style, but you cannot remove the original.
// You cannot rename the duplicate to that style.
if(myStyle.index == 1)
{ alert("Error: No custom paragraph style applied: [ Basic Paragraph Style ]"); return; }
// FWIW: Styles cannot be named with [ or ] in their names.
// [ and ] are restricted to the names of the base styles.
// Maybe there are other special characters that are not working?!
var myStyleName = myStyle.name;
var myStyleCopy = myStyle.duplicate();
app.menuActions.itemByID(8458).invoke();
myStyle.remove(myStyleCopy);
myStyleCopy.name = myStyleName;
}
catch(err) {
alert(err.message + ", line: " + err.line);
}
}
Regards,
Kasyan
Thank you to answer so quickly,
Checking if the menuItem is enabled before invoking it is basically what I already did in my first attempt http://robinfredericf.free.fr/misc/wadyms-paragraphstyle-trick_indd002.zip but I copied on this post only the most important line, assuming that people would check the link to see all the script, so if not the case here it is:
#target "InDesign";
$.localize = true;
$.locale = null;
//$.locale = "en";
function main() {
//var redefineParagraphStyle = app.menuActions.itemByID(132102);
/* « redefineParagraphStyle.invoke() » => Error « Script not activated. » */
/* cf. https://forums.adobe.com/thread/1961958 */
//var redefineParagraphStyle = app.menus[113].menuItems[3];
/* Marche dans InDesign CC 2015 mais dangereux car peut correspondre à une toute autre commande dans une autre version. */
/* cf. http://kasyan.ho.com.ua/open_menu_item.html https://forums.adobe.com/thread/892886 */
var redefineParagraphStyle = app.menus.item('$ID/ParaStylePanelPopup').menuItems.item('$ID/Redefine Style');
if (! redefineParagraphStyle.enabled) { throw new Error({
en: "This script is intended to be used when selecting (or placing the cursor in) some text that has a paragraph style applied "
+"and some unwanted overriden attributes that will be reverted to the style's values "
+"for all occurrences where the same overrides affect the same style in the document.",
fr: "The script est prévu pour être utilisé en sélectionnant (ou plaçant le curseur dans) du texte ayant un style de paragraphe appliqué "
+"et certains attributs affectés par des remplacements indésirables qui seront rétablis à la valeur du style "
+"pour toutes les occurrences où les mêmes remplacements affectent le même style dans le document."
}); }
var myStyle = app.activeDocument.selection[0].insertionPoints[0].appliedParagraphStyle;
var myStyleName = myStyle.name;
var myStyleCopy = myStyle.duplicate();
redefineParagraphStyle.associatedMenuAction.invoke();
myStyle.remove(myStyleCopy);
myStyleCopy.name = myStyleName;
}
try {
app.doScript(
function() { main(); },
ScriptLanguage.JAVASCRIPT,
undefined,
UndoModes.ENTIRE_SCRIPT,
File($.fileName).name
);
} catch(e) { alert(e); }
and I also already tried app.findKeyStrings() to get other variant of the locale-independent string, so in http://robinfredericf.free.fr/misc/wadyms-paragraphstyle-trick_indd002a.zip I tried to replace '$ID/Redefine Style' with '$ID/RedefineStyle' — expecting that it might be better without space.
I also presume my colleague knows that he has to select some text that is showing overrides on the applied paragraph style, before running the script, because it was first his own idea and because I explained how to use the script on the demo idml file included with the jsx in the zip. From that screenshot he sent me he seems to be correctly attempting to use the script when the error message occurs:
I wonder if other users would get the same error when trying the script wadyms-paragraphstyle-trick_indd002.jsx on the document wadyms-paragraphstyle-trick_indd002.idml, for example on a German InDesign version.
Thank you both for your suggestions, so June the 12th I uploaded this http://robinfredericf.free.fr/misc/wadyms-paragraphstyle-trick_indd003.zip but then there was the summer holidays and after them we were too busy. Recently I also tried something else to avoid the use of menu item invocation http://robinfredericf.free.fr/misc/wadyms-paragraphstyle-trick_indd006.zip attempting to emulate the "Redefine Style" command using something like that:
myStyle.properties = app.activeDocument.selection[0].insertionPoints[0].properties;
It works on InDesign CC but does nothing on InDesign CS5. Moreover it seems quite hazardous because it is not really equivalent to the original manual trick (I had to surround it by additional code intended to avoid the redefinition to include attributes from character styles, nested styles, grep styles…).
So I rather suggested my colleague to try the previous wadyms-paragraphstyle-trick_indd003.jsx version:
// indd002-MinimumVersion-2.jsx
#target "InDesign";
#targetengine reformatToAppliedStyle
app.doScript
(
reformatToAppliedStyle,
ScriptLanguage.JAVASCRIPT,
undefined,
UndoModes.ENTIRE_SCRIPT,
"Script | Undo Action"
);
function reformatToAppliedStyle()
{
if(app.documents.length == 0){ return; } // Do we need an alert here? No.
if(app.selection.length != 1){ return; } // Do we need an alert here? No.
if(!app.selection[0].hasOwnProperty("baselineShift"))
{ alert("Error: No text selected."); return; }
if(app.selection[0].styleOverridden == false)
{ alert("Error: No style override detected."); return; }
var menuItem = app.menus.item("$ID/ParaStylePanelPopup").menuItems.item("$ID/Redefine Style");
if(menuItem.isValid == false)
{ alert("Error: menuItem Redefine Style cannot be found."); return; }
if(menuItem.enabled == false)
{ alert("Error: menuItem Redefine Style is not enabled."); return; }
var myStyle = app.activeDocument.selection[0].insertionPoints[0].appliedParagraphStyle;
/*
// [ No Paragraph Style ] used.
NOTE: The following if statement should never be executed
if [ No Paragraph Style ] is really used on selected text,
because "Redefine Style" is never enabled with [ No Paragraph Style ]
and we already have an error condition for that case.
Nevertheless:
You cannot duplicate [ No Paragraph Style ]
*/
if(myStyle.index == 0)
{ alert("Error: No custom paragraph style applied: [ No Paragraph Style ]"); return; }
// [ Basic Paragraph Style ] used.
// You can duplicate that style, but you cannot remove the original.
// You cannot rename the duplicate to that style.
if(myStyle.index == 1)
{ alert("Error: No custom paragraph style applied: [ Basic Paragraph Style ]"); return; }
// FWIW: Styles cannot be named with [ or ] in their names.
// [ and ] are restricted to the names of the base styles.
// Maybe there are other special characters that are not working?!
var myStyleName = myStyle.name;
var myStyleCopy = myStyle.duplicate();
menuItem.associatedMenuAction.invoke();
myStyle.remove(myStyleCopy);
myStyleCopy.name = myStyleName;
}
Expecting that your in-depth error handling would enable us to dig what’s wrong with his localized InDesign versions. But he gets those errors:
So both CC and CS5.5 screenshots basically say the same thing:
JavaScript Ошибка! = JavaScript Error!
Номер ошибки = Error number: 45
Сообщение об ошибке = Error report: Недопустимый объект = Object is invalid
Файл = File: C:\Users\Вадим\AppData\Roaming\Adobe\InDesign\Version 11.0/7.5\ru_RU\Scripts\Scripts Panel\wadyms-paragraphstyle-trick_indd003.jsx
Строка = Line: 7
Источник = Source: (
He seems to have problems with the doScript() method, so I will try without it…
AdChoices
