Copy link to clipboard
Copied
Revision: 10766
Author: gruehle@adobe.com
Date: 2009-09-30 15:55:55 -0700 (Wed, 30 Sep 2009)
Log Message:
***********
Re-commit compiler errors for other theme's styles feature. If Style metadata has a "themes" attribute, the style is only valid if that theme is applied.
The Spark theme is applied by default. The halo theme can be specified as a compiler argument or by selecting the "MX Only" component set in Builder.
All other themes need to be applied using theme+= instead of theme=. If you use theme= you will get warnings about styles used in CSS selectors, and errors if you use any theme-specific style as an attribute on an MXML tag.
By default, styles that aren't valid for the current theme are errors. These can be changed to warnings with the report-invalid-styles-as-warnings compiler option.
QE notes: Expect test breakage
Doc notes: The new policy for themes needs to be documented.
Bugs: none yet, but I'm sure there will be some...
Reviewer: Ryan
Tests run: checkintests, cyclone
Is noteworthy for integration: Yes
Modified Paths:
**************
flex/sdk/trunk/frameworks/projects/framework/defaults.css
flex/sdk/trunk/frameworks/projects/framework/src/mx/containers/ApplicationControlBar.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/containers/ControlBar.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/Button.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/ButtonBar.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/CalendarLayout.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/ComboBase.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/DateChooser.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/RadioButton.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/TextArea.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/ToolTip.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/Tree.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/VideoDisplay.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/colorPickerClasses/SwatchPanel.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/listClasses/ListBase.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/core/ScrollControlBase.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/managers/CursorManager.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/skins/halo/ToolTipBorder.as
flex/sdk/trunk/frameworks/projects/framework/src/mx/styles/metadata/SkinStyles.as
flex/sdk/trunk/frameworks/projects/halo/defaults.css
flex/sdk/trunk/frameworks/projects/spark/defaults.css
flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/SkinnableDataContainerSkin.mxml
flex/sdk/trunk/frameworks/projects/sparkskins/src/SparkSkinsClasses.as
flex/sdk/trunk/frameworks/tests/basicTests/BasicTests.css
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/common/CompilerConfiguration.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/common/DefaultsConfigurator.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/common/MxmlConfiguration.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/css/StylesContainer.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/fxg/FXGCompiler.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/ImplementationCompiler.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/InterfaceCompiler.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/MxmlConfiguration.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/ComponentBuilder.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/lang/AttributeHandler.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/lang/DeclarationHandler.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/reflect/Type.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/reflect/TypeTable.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocument.java
flex/sdk/trunk/modules/compiler/src/java/flex2/compiler_en.properties
flex/sdk/trunk/modules/compiler/src/java/flex2/tools/PreLink.java
Added Paths:
***********
flex/sdk/trunk/frameworks/themes/Spark/spark.css
Removed Paths:
*************
flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/ApplicationBackground.as