Function is not returning value of the correct type

[Dbast]

I am setting up a ColdFusion component to rotate banner ads. The code (borrowed very heavily from Ben Forta's Web Application Kit) works well ... except after it's rotated through all the ads (I have four right now), I get an error: "The value returned from function CurrentAdId() is not of type numeric."

I'm not sure how much of the code you will need to see, so I'm pasting all of it here. I apologize if it's way more than necessary, and will appreciate any help you can offer! --diane

[LeftCorner]

Here is the dirty fix, I'm heading off to sleep.

If the function CurrentAdId doesn't return a number, then this will ensure it returns 0 (prevents your error, may not display an ad):

<CFFUNCTION
NAME="CurrentAdId"
ACCESS="Private"
RETURNTYPE="numeric"
HINT="For internal use. Returns the Id of the current ad in rotation.">

<!--- Return the adId from the current row of the GetAdIds query --->
<cfset var returnVal = ListGetAt(THIS.AdList, THIS.CurrentListPos)>

<cfif NOT IsNumeric(returnVal)>
<cfset returnVal = 0>
</cfif>

<CFRETURN returnVal>
</CFFUNCTION>

[Dbast]

LeftCorner: I can see where this *should* have worked, but it did not. Same error message. --diane

[BKBK]

The function CurrentAdId() returns an item from a list. Apparently, the list comprises strings. I would therefore change the return-type to "Any" or "String".