Someone may disagree with me, but in my opinion, you're making it more complicated than it needs to be.
First, let's look at fixing up the code you have currently.
Instead of hardcoding the indexes of aDoc.selection, you can run a loop to execute some code to each existing selected item. When you hard code things as you've done in the snippet you posted, you run the risk of a runtime error if something doesn't exist. You've identified this issue yourself when you pointed out that the code you have currently won't work properly if there's only one item in your selection. So, let's take a look at that necessary loop.
function container()
{
var aDoc = app.activeDocument;
var artboards = aDoc.artboards;
app.coordinateSystem = CoordinateSystem.ARTBOARDCOORDINATESYSTEM;
var abIdx = artboards.getActiveArtboardIndex();
var actAbBds = artboards[abIdx].artboardRect;
var sel = aDoc.selection;
//begin loop
for(var a=0 ; a<sel.length ; a++)
{
//here we're declaring the variable obj2move and setting it equal to
//the index "a" of the current selection.
//This way, the code will repeat until you've processed all of the selected items
//whether the number of selected items is 1, or 100, or more.
var obj2move = sel;
obj2move.position = new Array ((actAbBds[2]-actAbBds[0])/2 - obj2move.width/2, (actAbBds[3]-actAbBds[1])/2 + obj2move.height/2);
}
}
container();
When you can, you should try to avoid embedding calculations in an argument like you do in your "new Array" constructor. It's easier to read, fix and debug if you save those calculations into variables, like so:
function container()
{
var aDoc = app.activeDocument;
var artboards = aDoc.artboards;
app.coordinateSystem = CoordinateSystem.ARTBOARDCOORDINATESYSTEM;
var abIdx = artboards.getActiveArtboardIndex();
var actAbBds = artboards[abIdx].artboardRect;
var hCenter = (actAbBds[2] - actAbBds[0]) / 2;
var vCenter = (actAbBds[3] - actAbBds[1]) / 2;
var sel = aDoc.selection;
//begin loop
for(var a=0 ; a<sel.length ; a++)
{
var obj2move = sel;
var halfW = obj2move.width/2;
var halfH = obj2move.height/2;
var x = hCenter - halfW;
var y = vCenter + halfH;
//you'll also notice that i dropped the Array constructor syntax in favor
//of the 'array literal' syntax. I've been taught in school recently that this
//method is preferred and agreed to be the 'standard', though both approaches
//will work equally as well.
obj2move.position = [x,y];
}
}
container();
This way, if you see a problem with the vertical centering for instance, it's easier to look specifically at the parts of the code that relate specifically to the vertical centering and ignore the horizontal or vice versa. Not to mention, if you decide you need to access those same values later, you'll have variables accessible to use so you don't have to re-type the equation again.
1 Correct answer
6
Replies
AdChoices