10 Replies Latest reply on Dec 19, 2016 1:06 AM by joinupd74230013

Plugin is silently skipped if it fails the cordova requirement

phonegapps Nov 4, 2016 2:03 AM

If I use version 1.9.0 of plugin phonegap-plugin-push, Phonegap Build silently skips it, meaning that the build is successful, but the app doesn't contain the plugin. Looking at the logs I see

Fetching plugin "phonegap-plugin-push@1.9.0" via npm

Installing "phonegap-plugin-push" at "1.9.0" for android

Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed version requirement: >=6.4.0

Skipping 'phonegap-plugin-push' for android

The logical thing to do would be to make the build fail.

1. Re: Plugin is silently skipped if it fails the cordova requirement

simon.macdonald Nov 4, 2016 5:15 AM (in response to phonegapps)

Well two things, one that's not exactly silent as you do get a warning message and two that would be a change to the behaviour of PhoneGap/Cordova which is not something we can really do in a forum. Better to raise an issue at:

Apache Cordova Reporting Issues - Apache Cordova
Like Show 0 Likes(0)

Actions
2. Re: Plugin is silently skipped if it fails the cordova requirement

ioannis.cherouvim Nov 4, 2016 7:17 AM (in response to simon.macdonald)

The build is successful so the application may fail on runtime. Sorry mate, but that's pretty silent
Like Show 0 Likes(0)

Actions
3. Re: Plugin is silently skipped if it fails the cordova requirement

phonegapps Nov 6, 2016 7:07 PM (in response to simon.macdonald)

As ioannis.cherouvim said, it's quite silent as the app was successfully compiled but wasn't working correctly. I only check the logs on PGB if there's an error.

So this is a Cordova issue? I would have thought it's linked to PGB. Anyway I feel like it's the normal thing to do to make the build fail, else the user expects everything to be fine, which is never the case if a plugin is not included.

Also I posted in this forum as that's what's written on GitHub - phonegap/build: This is the public repository for PhoneGap Build source and bug tracking If indeed it's a Cordova issue, I'll add something in their JIRA.
Like Show 0 Likes(0)

Actions
4. Re: Plugin is silently skipped if it fails the cordova requirement

simon.macdonald Nov 7, 2016 4:05 AM (in response to phonegapps)

It is 100% a Cordova issue. Please raise the issue on the Cordova bug tracker. This is the same behaviour whether you use PGB or the Cordova CLI.

In the meantime you can upgrade the cordova, cordova-android and cordova-ios versions or stick with version 1.8.4.
Like Show 0 Likes(0)

Actions
5. Re: Plugin is silently skipped if it fails the cordova requirement

phonegapps Nov 7, 2016 7:59 PM (in response to simon.macdonald)

Thanks Simon,

[CB-12122] Incompatible plugin should make the build fail, not be skipped silently - ASF JIRA

In the meantime I indeed reverted back to 1.8.4.
Like Show 0 Likes(0)

Actions
6. Re: Plugin is silently skipped if it fails the cordova requirement

simon.macdonald Nov 8, 2016 4:30 AM (in response to phonegapps)

Thanks, I've started watching the issue and we are already discussing it on the dev mailing list. Issues like this have more weight when they come from the community.
Like Show 0 Likes(0)

Actions
7. Re: Plugin is silently skipped if it fails the cordova requirement

benjamino96587917 Nov 19, 2016 4:00 AM (in response to phonegapps)

I have the same issue even though it clearly says my app has been built with cli-6.4.0.

My config.xml:
My app's page on PGB:

logs from PGB:
Fetching plugin "phonegap-plugin-push" via npm Installing "phonegap-plugin-push" at "1.9.0" for android Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed version requirement: >=6.4.0 Skipping 'phonegap-plugin-push' for android

Supported cli versions by PGB:

For now I'll be rolling back to 1.8.4.
Like Show 1 Likes(1)

Actions
8. Re: Plugin is silently skipped if it fails the cordova requirement

joinupd74230013 Dec 16, 2016 12:36 AM (in response to benjamino96587917)

Now the push plugin (version 1.8.4) does not work in iOS10... so now it is not a solution rolling back to 1.8.4.
Like Show 0 Likes(0)

Actions
9. Re: Plugin is silently skipped if it fails the cordova requirement

simon.macdonald Dec 16, 2016 7:18 AM (in response to joinupd74230013)

Please try 1.9.1 with PGB now. The team made some changes yesterday which should resolve the issue. Please let me know if it works for you.
Like Show 0 Likes(0)

Actions
10. Re: Plugin is silently skipped if it fails the cordova requirement

joinupd74230013 Dec 19, 2016 1:06 AM (in response to simon.macdonald)

Same error :-(

1.9.1 version:

Repository "https://github.com/phonegap/phonegap-plugin-push.git" checked out to git ref "v1.9.1" at "6178688".
Installing "phonegap-plugin-push" at "1.9.1" for ios
Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed version requirement: >=6.4.0

1.9.2 version:

Repository "https://github.com/phonegap/phonegap-plugin-push.git" checked out to git ref "v1.9.2" at "ef3de32".
Installing "phonegap-plugin-push" at "1.9.2" for ios
Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed version requirement: >=6.4.0

Is there a way to set cordova version? It seems this does not work:

<engine name="ios" spec="4.3.0" />
<preference name="phonegap-version" value="cli-6.4.0" />

Other important lines:

....
<preference name="phonegap-version" value="cli-6.4.0" />
<engine name="ios" spec="4.3.0" />
....
<plugin name="phonegap-plugin-push" spec="https://github.com/phonegap/phonegap-plugin-push.git#v1.9.1" source="git">
<param name="SENDER_ID" value="XXXXXX" />
</plugin>
....
Like Show 0 Likes(0)

Actions

Go to original post