Dont use a mask from the Crop effect but rather from Opacity.
I also see two masks they might overlap each other.
Post a screenshot of the diagonal mask highlighted (click on the word Mask in the Effect Controls) so we can see the nodes, also zoom/magnify out so we can see outside the frame.
For straight lines make sure the nodes don't have bezier handles.
Hold Alt when clicking on node for them to change.