0 Replies Latest reply on Sep 30, 2008 3:43 PM by Glenn Ruehle

    [svn] 3430: This is a collection of minor component changes, done for consistency.

    Glenn Ruehle Adobe Employee
      Revision: 3430
      Author: gruehle@adobe.com
      Date: 2008-09-30 16:43:13 -0700 (Tue, 30 Sep 2008)

      Log Message:
      -----------
      This is a collection of minor component changes, done for consistency.

      * Data is always "pushed" into skin parts. We were doing this in some places like ItemsComponent.contentGroup, but not in other places. Affected components are TextInput, TextArea, NumericStepper, and Button.

      * Button (and every subclass) has an optional "labelField" SkinPart. The Button "label" property is pushed into this part if it is defined.

      * Added skin states to the following components:
      TrackBase (includes H/VScrollBar and H/VSlider): States "normal" and "disabled".
      Spinner (includes NumericStepper): States "normal" and "disabled".
      ContainerBase (includes ItemsComponent, Selector, and List): States "normal" and "disabled".

      The appearance of "disabled" states is controlled by the skin. The behavior of "disabled" states is still controlled by the component (ie ScrollBar disables the thumb, track and arrow when it is disabled).

      * Added new ContainerBase class, which is the base class for ItemsComponent and DataComponent. The base class manages the skin states and puts up a mouse shield when disabled.

      * Thumb positioning code in slider and scrollbar always rounds to the nearest pixel boundary. Sub-pixel positioning makes the thumbs look blurry.

      * TextView measurement is rounded to integer values. It was commonly returning non-integer values which was causing subsequent components in relative layouts to be positioned on sub-pixel boundaries.

      Bugs: SDK-16933 Make Label be an optional part of Button and related components
      QE: The pixel alignment changes may result in bitmap comparison failures. The bitmaps should be regenerated with the pixel alignment. There should be no functional changes to any of the components.
      Reviewer: Chet, Ryan

      Ticket Links:
      ------------
      http://bugs.adobe.com/jira/browse/SDK-16933

      Modified Paths:
      --------------
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/Button.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/DataComponent.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/HScrollBar.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/HSlider.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/ItemsComponent.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/NumericStepper.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/Spinner.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/TextBase.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/TextInput.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/TextView.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/TrackBase.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/VScrollBar.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/VSlider.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/ApplicationSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/ButtonSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/CheckBoxSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/ComplexPanelSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/DataComponentSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/HScrollBarSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/HSliderSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/ItemsComponentSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/ListSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/NumericStepperSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/PanelSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/RadioButtonSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/SelectorSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/SpinnerSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/TextAreaSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/TextInputSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/ToggleButtonSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/VScrollBarSkin.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/skin/VSliderSkin.mxml

      Added Paths:
      -----------
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/ContainerBase.as