0 Replies Latest reply on Nov 13, 2008 5:56 PM by (Ryan_Frishberg)

    [svn] 4106: Mostly rename changes.

    Level 1
      Revision: 4106
      Author: rfrishbe@adobe.com
      Date: 2008-11-13 17:56:47 -0800 (Thu, 13 Nov 2008)

      Log Message:
      -----------
      Mostly rename changes. IVisualItem -> IVisualElement. IVisualContainer -> IVisualElementContainer. Also changed the APIs so that it's addElement, removeElement, etc.. instead of addItem, removeItem, etc... Moreover, all of these APIs have been added to IVisualElementContainer (not just the read-only ones). Now there's a common interface for all containers (even Halo's Container class implements it). There's no more need to do:

      if (x is Group || x is FxContainer)

      Just use the IVisualElementContainer interface.

      Some classes, like FxScroller (and perhaps DataGroup/FxDataContainer), will only implement the "getter" part of the API. For now, if you call the mutation methods, we will throw an exception. Perhaps later we'll add a separate interface for the read-only portion and the mutator interface will extend that one.

      There might be a few more places in the code that need to be updated to use the new names for the methods. I know Mustella needs cleaning up so it doesn't use getItem and uses getElement instead. I've left the old APIs in there exactly for this purpose, so we can gradually move over to the new names (esp. QA).

      At some point soon, we will remove the old methods as well as type them more strictly to only accept IVisualElements, for example addElement(element:IVisualElement). Part of this work is dependent on updating the Flash Component Kit so that it implements IVisualElement (and perhaps IVisualElementContainer for containers).

      Ran checkintests and all gumbo mustella tests.

      QE Notes: Please update your tests to use addElement, removeElement, etc... along with the new IVisualElementContainer interface. The old APIs (addItem, removeItem, etc...) will be removed soon.
      Doc Notes: None
      Bugs: -
      Reviewer: Hans (he patiently sat through all these files...)

      Modified Paths:
      --------------
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/components/DataGroup.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/components/FxContainer.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/components/FxList.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/components/FxScroller.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/components/Group.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/AddAction.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/RemoveAction.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/effectClasses/AddActionInstance.a s
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/effectClasses/FxAnimate3DInstance .as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/effectClasses/FxAnimateInstance.a s
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/effectClasses/FxFadeInstance.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/effectClasses/RemoveActionInstanc e.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/graphics/graphicsClasses/GraphicElement.a s
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/layout/ILayoutItem.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/layout/LayoutItemHelper.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/layout/LayoutItemUIC.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/states/AddItems.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/core/Container.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/core/IUIComponent.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/core/UIComponent.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/styles/StyleProtoChain.as
      flex/sdk/trunk/tools/dependencychecker/flex/tools/dependencychecker/FrameworkSwcDependenc yRules.java

      Added Paths:
      -----------
      flex/sdk/trunk/frameworks/projects/framework/src/mx/core/IVisualElement.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/core/IVisualElementContainer.as

      Removed Paths:
      -------------
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/core/IVisualContainer.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/core/IVisualItem.as