0 Replies Latest reply on Mar 20, 2008 10:30 AM by (Paul_Reilly)

    [svn] 876:

    Level 1
      Revision: 876
      Author: preilly@adobe.com
      Date: 2008-03-20 11:30:12 -0700 (Thu, 20 Mar 2008)

      Log Message:

      Reverted part of mecurial ASC change 117, by changing uint constants
      back to double constants when the abc version is TARGET_AVM1 due to
      bug ASC-3212. The actual fix for this bug requires changing
      ActionBlockConstants.cpp in avmplus to use OP_pushuint for
      CONSTANT_UInt, but we can't fix that in AVM1 since it has already
      shipped. A follow on checkin will fix it for Flash 10.

      Needs QA: YES, ASC sanity tests pass.

      Needs DOC: NO

      Bug fixes: ASC-3212

      API Change: NO

      Code reviewed by: etierney

      Code-level description of changes:

      Modified getValueIndex() and FinishMethod() to follow the doubleType
      code path for uint's when abc version is TARGET_AVM1.

      Modified getValueKind() to return CONSTANT_Double when the
      defaultValueType is uintType and the abc version is TARGET_AVM1.

      Modified PushNumber() to follow the TYPE_int when te type_id is
      TYPE_uint and when the abc version is TARGET_AVM1.

      Ticket Links:

      Modified Paths:
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/embedding/avmplus/ActionBlockEmitter.j ava