0 Replies Latest reply on Dec 23, 2008 2:00 AM by (Ryan_Frishberg)

    [svn] 4380: Mostly rename changes in Group and FxContainer.

      Revision: 4380
      Author: rfrishbe@adobe.com
      Date: 2008-12-23 02:00:21 -0800 (Tue, 23 Dec 2008)

      Log Message:
      -----------
      Mostly rename changes in Group and FxContainer.

      1. GraphicElement.elementHost:GroupBase -> GraphicElement.parent:DisplayObjectContainer (parent already exists in the current code-base...I?\226?\128?\153m just removing elementHost now)

      2. Group content APIs now use ?\226?\128?\156element?\226?\128?\157 instead of ?\226?\128?\156item.?\226?\128?\157 The new methods were added a while ago, but the old ones co-existed. These particular changes remove the old methods and strongly type the new ones to deal with IVisualElements rather than Objects. Here are the overall changes:

      numItems:int -> numElements:int
      getItemAt(int):Object -> getElementAt(int):IVisualElement
      addItem(Object):Object -> addElement(IVisualElement):IVisualElement
      addItemAt(Object, int):Object -> addElementAt(IVisualElement, int):IVisualElement
      removeItem(Object):Object -> removeElement(IVisualElement):IVisualElement
      removeItemAt(int):Object -> removeElementAt(int):IVisualElement
      getItemIndex(Object):int -> getElementIndex(IVisualElement):int
      setItemIndex(Object, int):void -> setElementIndex(IVisualElement, int):void
      swapItems(Object, Object):void -> swapElements(IVisualElement, IVisualElement):void
      swapItemsAt(int, int):void -> swapElementsAt(int, int):void

      3. Group and FxContainer's mxmlContent property is now strongly typed as an Array of IVisualElements instead of an Object

      4. Removing ITransformable...there's no need for it.

      5. Had to update Mustella for these changes (the Perforce changes are checked in, and here's the mustella.swc change for checkintests)

      QE Notes: Joan and Steve worked with me on changing all the SDK QA tests.
      Doc Notes: None
      Bugs: SDK-18063
      Reviewer: Jason
      tests: checkintests, Mustella FxContainer, Group, and DataGroup (Joan ran all tests on an earlier version of these changes, so hopefully nothing broke in the meantime). Some of the Group/DataGroup ones were failing for me, but I'm pretty sure they're all excluded (tests don't seem to exclude for me when I VPN in...)

      Ticket Links:
      ------------
      http://bugs.adobe.com/jira/browse/SDK-18063

      Modified Paths:
      --------------
      flex/sdk/trunk/development/eclipse/flex/flex4test/src/layouts/WheelLayout.as
      flex/sdk/trunk/development/eclipse/flex/flex4test/src/testWheel.mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/components/FxContainer.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/components/FxScroller.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/components/Group.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/components/ItemRenderer.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/core/IViewport.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/AddAction.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/RemoveAction.as
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/effects/effectClasses/FxAnimateInstance.a s
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/graphics/graphicsClasses/GraphicElement.a s
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/skins/spark/FxDefaultComplexItemRenderer. mxml
      flex/sdk/trunk/frameworks/projects/flex4/src/mx/states/AddItems.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/core/Container.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/core/IVisualElement.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/core/IVisualElementContainer.as
      flex/sdk/trunk/frameworks/projects/framework/src/mx/geom/TransformOffsets.as
      flex/sdk/trunk/frameworks/projects/wireframe/src/wireframe/FxDefaultComplexItemRenderer.m xml
      flex/sdk/trunk/frameworks/tests/flex4/flex4test_testScript.mxml
      flex/sdk/trunk/mustella/mustella.swc

      Removed Paths:
      -------------
      flex/sdk/trunk/frameworks/projects/framework/src/mx/geom/ITransformable.as