0 Replies Latest reply on Jan 27, 2009 1:12 PM by (Paul_Reilly)

    [svn] 4690: * Fixed an issue caused by revision 4330.

    Level 1
      Revision: 4690
      Author: preilly@adobe.com
      Date: 2009-01-27 13:12:47 -0800 (Tue, 27 Jan 2009)

      Log Message:
      -----------
      * Fixed an issue caused by revision 4330. Due to leaving the backing
      variables and functions in the public namespace, they were showing
      up in FlexBuilder's code hinting and DataGrid's without specified
      columns. Now they are "hidden" in the mx_internal namespace.

      tests Passed: checkintests, mxunit databinding

      Needs QA: YES

      Needs DOC: NO

      Bug fixes: SDK-18853, SDK-18604

      API Change: NO

      Reviewer: Pete F.

      Code-level description of changes:

      frameworks/projects/framework/src/mx/binding/BindingManager.as

      Modified set() to no longer require a userNamespace arg. The
      mx_internal namespace is now assumed.

      modules/compiler/src/java/flex2/compiler/as3/genext/GenerativeSecondPassEvaluator.java

      Renamed makeAttrListPublic() to makeMxInternalAndRemoveOverride(DefinitionNode)
      and updated it to handle IdentifierNodes in the
      AttributeListNode's items.

      Added makeMxInternalAndRemoveOverride(IdentifierNode, Iterator) as
      a helper method for common code in
      makeMxInternalAndRemoveOverride(DefinitionNode).

      modules/compiler/src/java/flex2/compiler/as3/genext/GenerativeClassInfo.java

      Modified AccessorInfo's constructor to create a more unique backingPrefix.

      Modified getQualifiedBackingPropertyName() to always use the
      mx_internal namespace.

      modules/compiler/src/java/flex2/compiler/as3/binding/BindableProperty.vm

      Modified BindingManager.set() call to no longer pass in the userNamespace.

      modules/compiler/src/java/flex2/compiler/as3/binding/BindableFirstPassEvaluator.java

      Modified evaluate(Context, ClassDefinitionNode) to add an import
      for mx_internal.

      Ticket Links:
      ------------
      http://bugs.adobe.com/jira/browse/SDK-18853
      http://bugs.adobe.com/jira/browse/SDK-18604

      Modified Paths:
      --------------
      flex/sdk/trunk/frameworks/projects/framework/src/mx/binding/BindingManager.as
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/binding/BindableFirstPassEval uator.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/binding/BindableProperty.vm
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/genext/GenerativeClassInfo.ja va
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/genext/GenerativeSecondPassEv aluator.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/managed/ManagedProperty.vm