0 Replies Latest reply on Apr 1, 2009 10:06 AM by (Ryan_Frishberg)

    [svn:fx-trunk] 5841: Changing the lifecycle of the layout object in GroupBase.

      Revision: 5841
      Author: rfrishbe@adobe.com
      Date: 2009-04-01 11:06:53 -0700 (Wed, 01 Apr 2009)

      Log Message:
      -----------
      Changing the lifecycle of the layout object in GroupBase. Before, we?\226?\128?\153d always instantiate one in GroupBase?\226?\128?\153s constructor. Now, we wait until createChildren() time to instantiate the default. This means if people set the layout object, we won?\226?\128?\153t be creating this extra BasicLayout we don?\226?\128?\153t need. There was an assumption in GroupBase around some of the proxied properties that the layout object was always going to be present. These are cleaned up for when the layout object doesn?\226?\128?\153t always exist. Also, now when the layout object is swapped at runtime, the verticalScrollPosition and horizontalScrollPosition don?\226?\128?\153t get pushed into the new layout object, as they may not translate correctly. We discussed the possibility of sending in a ?\226?\128?\156first item in view?\226?\128?\157 for when the layout object is swapped, but for now, we don?\226?\128?\153t do anything like that.

      Also fixing a bug in components.properties and some spelling errors in SkinnableDataContainer.

      QE Notes: Fix the tests that were failing and re-include them
      Doc Notes: -
      Bugs: SDK-19769, SDK-20163
      Reviewer: Hans
      tests: checkintests, mustella core and layout tests

      Ticket Links:
      ------------
      http://bugs.adobe.com/jira/browse/SDK-19769
      http://bugs.adobe.com/jira/browse/SDK-20163

      Modified Paths:
      --------------
      flex/sdk/trunk/frameworks/projects/flex4/bundles/en_US/components.properties
      flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/Group.as
      flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/HGroup.as
      flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/SkinnableDataContainer.as
      flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/VGroup.as
      flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/supportClasses/GroupBase.as