0 Replies Latest reply on May 2, 2008 12:23 PM by (Paul_Reilly)

    [svn] 1541: Fixed exception introduced by revision 1514 when compiling the

    Level 1
      Revision: 1541
      Author: preilly@adobe.com
      Date: 2008-05-02 13:23:07 -0700 (Fri, 02 May 2008)

      Log Message:
      -----------
      Fixed exception introduced by revision 1514 when compiling the
      Hospital app and addressed some of the performance impact of revision
      1456. With Dorado, YourKit reported the error reporting support
      (revision 1456) lost us about four seconds. These changes gain us
      back two.

      checkintests Passed: YES

      Needs QA: YES

      Needs DOC: NO

      API Change: NO

      Code-level description of changes:

      lib/asc.jar

      Rebuilt with EmptyStatementNode.java change.

      modules/asc/src/java/macromedia/asc/parser/EmptyStatementNode.java

      Modified evaluate() to no longer call checkFeature() and just
      return null. CodeGenerator.checkFeature()'s calls getLnNum() and
      getColPos() on the InputBuffer and it seems unnecessary to do
      this for EmptyStatementNodes and it happens to make a small
      difference with large apps like Dorado.

      modules/compiler/src/java/flex2/compiler/as3/CodeFragmentsInputBuffer.java

      Modified getLnNum() to no longer subtract out the start position,
      because due to revision 1514, it is no longer necessary.

      Modified lookupCodeFragment() to skip the lookup, when the
      position is -1, which means there isn't an associated
      CodeFragment. The position for all the directly generated Nodes
      is -1.

      Modified Paths:
      --------------
      flex/sdk/trunk/lib/asc.jar
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/EmptyStatementNode.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/CodeFragmentsInputBuffer.java