0 Replies Latest reply on May 9, 2008 7:28 AM by (Paul_Reilly)

    [svn] 1631: Fixed Hospital app compilation by using the new OffsetInputBuffer.

    Level 1
      Revision: 1631
      Author: preilly@adobe.com
      Date: 2008-05-09 08:28:23 -0700 (Fri, 09 May 2008)

      Log Message:
      -----------
      Fixed Hospital app compilation by using the new OffsetInputBuffer.

      Reduced String.intern() calls by telling ASC not to intern constants,
      which are used during direct AST generation, because they have already
      been interned.

      testsuites Passed: checkintests, mxunit compiler, mxmlcunit compiler
      (one new unrelated failure due to signature
      changes), performance

      Needs QA: YES

      Needs DOC: NO

      API Change: NO

      Reviewer: tierney, pfarland

      Code-level description of changes:

      modules/asc/src/java/macromedia/asc/parser/NodeFactory.java

      Modified identifier() to use a constant for "arguments" and to use
      == comparison since both sides have been interned.

      Added new identifier() and literalString() variants to support
      String.intern() avoidance.

      modules/asc/src/java/macromedia/asc/parser/LiteralStringNode.java

      Added new constructor to support String.intern() avoidance.

      modules/asc/src/java/macromedia/asc/parser/Scanner.java

      Added new constructor to support passing in a custom InputBuffer.

      modules/asc/src/java/macromedia/asc/parser/Parser.java

      Added new constructor to support passing in a custom InputBuffer.

      modules/asc/src/java/macromedia/asc/parser/IdentifierNode.java

      Added new constructor to support String.intern() avoidance.

      Added constant for "*" and modified setName() to use == comparison
      since both sides have been interned.

      modules/compiler/src/java/flex2/compiler/as3/OffsetInputBuffer.java

      Initial checkin.

      modules/compiler/src/java/flex2/compiler/as3/AbstractSyntaxTreeUtil.java

      Modified parse() use an OffsetInputBuffer.

      Added intern avoidance support.

      modules/compiler/src/java/flex2/compiler/as3/binding/DataBindingExtension.java
      modules/compiler/src/java/flex2/compiler/mxml/rep/AtResource.java
      modules/compiler/src/java/flex2/compiler/mxml/rep/init/EffectInitializer.java
      modules/compiler/src/java/flex2/compiler/mxml/rep/init/ValueInitializer.java
      modules/compiler/src/java/flex2/compiler/mxml/rep/init/StyleInitializer.java
      modules/compiler/src/java/flex2/compiler/mxml/rep/init/EventInitializer.java
      modules/compiler/src/java/flex2/compiler/mxml/rep/init/VisualChildInitializer.java
      modules/compiler/src/java/flex2/compiler/mxml/rep/BindingExpression.java
      modules/compiler/src/java/flex2/compiler/mxml/InterfaceGenerator.java
      modules/compiler/src/java/flex2/compiler/mxml/AbstractGenerator.java
      modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

      Added intern avoidance support.

      Modified Paths:
      --------------
      flex/sdk/trunk/lib/asc.jar
      flex/sdk/trunk/modules/asc/build/java/build.xml
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/IdentifierNode.java
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/LiteralStringNode.java
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/NodeFactory.java
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/Parser.java
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/Scanner.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/AbstractSyntaxTreeUtil.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/CodeFragmentsInputBuffer.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/binding/DataBindingExtension. java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/AbstractGenerator.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/InterfaceGenerator.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/lang/StandardDefs.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/AtResource.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/BindingExpression.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/init/EffectInitializer.j ava
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/init/EventInitializer.ja va
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/init/StyleInitializer.ja va
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/init/ValueInitializer.ja va
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/init/VisualChildInitiali zer.java

      Added Paths:
      -----------
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/OffsetInputBuffer.java