0 Replies Latest reply on Jul 17, 2008 1:32 PM by Peter Farland

    [svn] 2521: Fixing special language attribute resolution to handle the special unqualified language attribute case ( a common case since the language namespace is usually the default for the document ).

    Peter Farland Level 3
      Revision: 2521<br />Author:   pfarland@adobe.com<br />Date:     2008-07-17 14:32:24 -0700 (Thu, 17 Jul 2008)<br /><br />Log Message:<br />-----------<br />Fixing special language attribute resolution to handle the special unqualified language attribute case (a common case since the language namespace is usually the default for the document). Exposed the Element.Value class as a better named and public Attribute class that allows a single lookup to determine an attribute value and line number.<br /><br />Enforcing further FXG rules - Library tags, if present, must be the first child node in a document (and note this is enforced for both FXG and MXML for now). Also note that an exception to this rule is the <mask> tag which can appear anywhere as a child of a Graphic root tag, including before a Library tag and after a Private tag.<br /><br />QE: Yes, please note the changes to Library tag rules and include tests to cover the <mask> special case which can appear anywhere under the root node of a document. I'll send you my test cases. Also note the error message has changed for duplicate Library tag, even if there are two Library tags used it will report that the second one is not the first element in the document (which now matches the Private tag validation).<br />Doc: Not yet.<br />Checkintests: Pass<br />Reviewers: Paul (SDK-15708), Carol (SDK-16124)<br />Bugs:<br />SDK-15708 - [MXML Namespaces] Values set for unqualified language attributes are not reflected on the swf <br />SDK-16124 - [FXG] Library tag should always be the first element in fxg file (when present)<br /><br />Ticket Links:<br />------------<br />    http://bugs.adobe.com/jira/browse/SDK-15708<br />    http://bugs.adobe.com/jira/browse/SDK-16124<br />    http://bugs.adobe.com/jira/browse/SDK-15708<br />    http://bugs.adobe.com/jira/browse/SDK-16124<br /><br />Modified Paths:<br />--------------<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/Element.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/InterfaceCompiler.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/analyzer/RemoteObjectAnalyze r.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/analyzer/SyntaxAnalyzer.java <br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/analyzer/WebServiceAnalyzer. java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/AbstractBuilder.java <br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/AnonymousObjectGraph Builder.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/ArrayBuilder.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/ComponentBuilder.jav a<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/DocumentBuilder.java <br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/InlineComponentBuild er.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/ModelBuilder.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/PrimitiveBuilder.jav a<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/RemoteObjectBuilder. java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/WebServiceBuilder.ja va<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/XMLBuilder.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/XMLListBuilder.java< br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/dom/XMLNode.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/lang/AttributeHandler.java<b r />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/lang/StandardDefs.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/DocumentInfo.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/StatesModel.java<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler_en.properties<br /><br />Added Paths:<br />-----------<br />    flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/Attribute.java