0 Replies Latest reply on Sep 5, 2008 10:40 AM by (Paul_Reilly)

    [svn] 3121: Optimized QualifiedIdentifierNode creation by not requiring a throw

      Revision: 3121
      Author: preilly@adobe.com
      Date: 2008-09-05 11:40:44 -0700 (Fri, 05 Sep 2008)

      Log Message:
      -----------
      Optimized QualifiedIdentifierNode creation by not requiring a throw
      away IdentifierNode. This reduces overall object creation and GC
      time.

      tests Passed: checkintests, asc-tests

      Needs QA: YES

      Needs DOC: NO

      API Change: NO

      Reviewer: tierney

      Code-level description of changes:

      asc/src/java/macromedia/asc/semantics/FlowAnalyzer.java
      compiler/src/java/flex2/compiler/as3/AbstractSyntaxTreeUtil.java
      compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

      Modified NodeFactory.qualifiedIdentifier() calls to use the
      IdentifierNode's name and position.

      asc/src/java/macromedia/asc/parser/NodeFactory.java

      Modified NodeFactory.qualifiedIdentifier() calls to use the
      IdentifierNode's name and position.

      Modified identifier(String, boolean) to call identifier(String,
      boolean, int).

      Modified identifier(String, boolean, int) to check for "arguments".

      Modified qualifiedIdentifier() to take a String instead of an
      IdentifierNode.

      asc/src/java/macromedia/asc/parser/QualifiedIdentifierNode.java

      Modified constructor to take a String instead of an IdentifierNode.

      asc/src/java/macromedia/asc/parser/Parser.java

      Added parseIdentifierString() and parsePropertyIdentifierString()
      and modified parseIdentifier() and parsePropertyIdentifier() to use
      them.

      Modified qualifiedIdentifier() calls to use parseIdentifierString()
      or parsePropertyIdentifierString().

      asc/src/java/macromedia/asc/parser/VariableDefinitionNode.java

      Modified NodeFactory.qualifiedIdentifier() call to use the
      IdentifierNode's name and position.

      Modified Paths:
      --------------
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/NodeFactory.java
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/Parser.java
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/QualifiedIdentifierNode.java
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/parser/VariableDefinitionNode.java
      flex/sdk/trunk/modules/asc/src/java/macromedia/asc/semantics/FlowAnalyzer.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/AbstractSyntaxTreeUtil.java
      flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java