0 Replies Latest reply on Sep 24, 2008 3:10 PM by (Ryan_Frishberg)

    [svn] 3341: Changing the definition of some methods in SkinnableComponent.

    Level 1
      Revision: 3341
      Author: rfrishbe@adobe.com
      Date: 2008-09-24 16:10:20 -0700 (Wed, 24 Sep 2008)

      Log Message:
      -----------
      Changing the definition of some methods in SkinnableComponent. So instead of:

      protected function partAdded(partName:String, instance:*):void

      We now have:

      protected function partAdded(partName:String, instance:Object):void

      Technically this just means we can't support the value of "undefined" anymore. This change was made to partAdded(), partRemoved(), createPartInstance(), removePartInstance(), and getDyanamicPartAt().

      As I was making these changes in all the files that override these methods, I noticed Slider should have a partRemoved() method, so I added it.

      I also made a minor change in Selector where there was a bug in the dataProvider collectionChange eventHandler. Basically we were doing remove code on replace rather than remove.

      QE: Yes - This will break (as in, it won't compile) some tests in SkinnableComponent. Joann will change them soon after I checkin.
      Doc: Yes
      Bugs: SDK-16640, SDK-16709
      Reviewer: Hans

      Ticket Links:
      ------------
      http://bugs.adobe.com/jira/browse/SDK-16640
      http://bugs.adobe.com/jira/browse/SDK-16709

      Modified Paths:
      --------------
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/DataComponent.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/ItemsComponent.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/List.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/NumericStepper.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/ScrollBar.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/Scroller.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/Selector.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/Slider.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/Spinner.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/TextArea.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/TextBase.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/TextInput.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/TrackBase.as
      flex/sdk/trunk/frameworks/projects/flex4/src/flex/core/SkinnableComponent.as