0 Replies Latest reply on Jun 10, 2009 5:25 PM by rfrishbe

    [svn:fx-trunk] 7732: VideoPlayer changes: mostly PARB but fixing a few bugs as well.

    rfrishbe Level 3

      Revision: 7732

      Author:   rfrishbe@adobe.com

      Date:     2009-06-10 16:24:50 -0700 (Wed, 10 Jun 2009)

       

      Log Message:

      ***********

      VideoPlayer changes: mostly PARB but fixing a few bugs as well.

       

      Bugs:

       

      Fix VideoPlayer bug with live streaming so the pause button comes up when we first start playing (rather than a play button).  This was caused by an underlying FLVPlayback VideoPlayer bug, and I modified the underlying VideoPlayer code to fix it.

       

      MuteButton wasn't showing the correct volume when it first pops up in fullScreen mode.  This is because the MuteButtonSkin needed to grab the volume property when it loaded up initially.  It was doing this in the normal case, but not the fullScreen and wireframe case.

       

      FullScreen DropShadow: Change volume bar dropshadow to be a real dropshadow instead of using RectangularDropShadow.  This is the same change as yesterday...just in the fullScreen case.

       

      API Changes:

       

      ScrubBar.bufferedRange:Array -> bufferedStart, bufferedEnd

       

      VolumeBar: Add isDropDownOpen() which facades to isOpen on the DropDownController.

       

      MuteButton:  Change ?\226?\128?\156value?\226?\128?\157 property to ?\226?\128?\156volume?\226?\128?\157.  Add ?\226?\128?\156muted?\226?\128?\157 property and a mutedChange event.

       

      Get rid of VideoPlayerVolumeBarEvent: put the constant on FlexEvent instead: FlexEvent.MUTED_CHANGE

       

      VideoPlayer.muteButton: Changed type from ToggleButton to MuteButton.

       

      Make DropDownList/VolumeBar.dropDownController_openHandler() and closeHandler() mx_internal instead of protected.

       

      Class Renames:

       

      spark.components.supportClasses.StreamingVideoSource -> spark.components.mediaClasses.StreamingVideoSource

      spark.components.supportClasses.StreamItem -> spark.components.mediaClasses.StreamItem

      spark.components.VideoPlayerScrubBar -> spark.components.mediaClasses.ScrubBar

      spark.components.VideoPlayerVolumeBar -> spark.components.mediaClasses.VolumeBar

      spark.components.VideoPlayerVolumeBarMuteButton -> spark.components.mediaClasses.MuteButton

       

      spark.skins.default.VideoPlayerFullScreenButtonSkin -> spark.skins.default.mediaClasses.normal.FullScreenButtonSkin

      spark.skins.default.VideoPlayerPlayPauseButtonSkin -> spark.skins.default.mediaClasses.normal.PlayPauseButtonSkin

      spark.skins.default.VideoPlayerScrubBarSkin -> spark.skins.default.mediaClasses.normal.ScrubBarSkin

      spark.skins.default.VideoPlayerScrubBarThumbSkin -> spark.skins.default.mediaClasses.normal.ScrubBarThumbSkin

      spark.skins.default.VideoPlayerScrubBarTrackSkin -> spark.skins.default.mediaClasses.normal.ScrubBarTrackSkin

      spark.skins.default.VideoPlayerVolumeBarMuteButtonSkin -> spark.skins.default.mediaClasses.normal.MuteButtonSkin

      spark.skins.default.VideoPlayerVolumeBarSkin -> spark.skins.default.mediaClasses.normal.VolumeBarSkin

      spark.skins.default.VideoPlayerVolumeBarThumbSkin -> spark.skins.default.mediaClasses.normal.VolumeBarThumbSkin

      spark.skins.default.VideoPlayerVolumeBarTrackSkin -> spark.skins.default.mediaClasses.normal.VolumeBarTrackSkin

       

      spark.skins.default.VideoPlayerFullScreenFullScreenButtonSkin -> spark.skins.default.mediaClasses.fullScreen.FullScreenButtonSkin

      spark.skins.default.VideoPlayerFullScreenPlayPauseButtonSkin -> spark.skins.default.mediaClasses.fullScreen.PlayPauseButtonSkin

      spark.skins.default.VideoPlayerFullScreenScrubBarSkin -> spark.skins.default.mediaClasses.fullScreen.ScrubBarSkin

      spark.skins.default.VideoPlayerFullScreenScrubBarThumbSkin -> spark.skins.default.mediaClasses.fullScreen.ScrubBarThumbSkin

      spark.skins.default.VideoPlayerFullScreenScrubBarTrackSkin -> spark.skins.default.mediaClasses.fullScreen.ScrubBarTrackSkin

      spark.skins.default.VideoPlayerFullScreenVolumeBarMuteButtonSkin -> spark.skins.default.mediaClasses.fullScreen.MuteButtonSkin

      spark.skins.default.VideoPlayerFullScreenVolumeBarSkin -> spark.skins.default.mediaClasses.fullScreen.VolumeBarSkin

      spark.skins.default.VideoPlayerFullScreenVolumeBarThumbSkin -> spark.skins.default.mediaClasses.fullScreen.VolumeBarThumbSkin

      spark.skins.default.VideoPlayerFullScreenVolumeBarTrackSkin -> spark.skins.default.mediaClasses.fullScreen.VolumeBarTrackSkin

       

      spark.skins.wireframe.VideoPlayerFullScreenFullScreenButtonSkin -> spark.skins.wireframe.mediaClasses.fullScreen.FullScreenButtonSkin

      spark.skins.wireframe.VideoPlayerFullScreenButtonSkin -> spark.skins.wireframe.mediaClasses.FullScreenButtonSkin

      spark.skins.wireframe.VideoPlayerPlayPauseButtonSkin -> spark.skins.wireframe.mediaClasses.PlayPauseButtonSkin

      spark.skins.wireframe.VideoPlayerScrubBarSkin -> spark.skins.wireframe.mediaClasses.ScrubBarSkin

      spark.skins.wireframe.VideoPlayerScrubBarThumbSkin -> spark.skins.wireframe.mediaClasses.ScrubBarThumbSkin

      spark.skins.wireframe.VideoPlayerScrubBarTrackSkin -> spark.skins.wireframe.mediaClasses.ScrubBarTrackSkin

      spark.skins.wireframe.VideoPlayerVolumeBarMuteButtonSkin -> spark.skins.wireframe.mediaClasses.MuteButtonSkin

      spark.skins.wireframe.VideoPlayerVolumeBarSkin -> spark.skins.wireframe.mediaClasses.VolumeBarSkin

      spark.skins.wireframe.VideoPlayerVolumeBarThumbSkin -> spark.skins.wireframe.mediaClasses.VolumeBarThumbSkin

      spark.skins.wireframe.VideoPlayerVolumeBarTrackSkin -> spark.skins.wireframe.mediaClasses.VolumeBarTrackSkin

       

      QE Notes: -

      Doc Notes: -

      Bugs: SDK-21727, SDK-21722, SDK-21675

      Reviewer: Deepa

      tests: checkintest (seem to fail due to local changes to ScrollBar, which I'm not checking in here)

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-21727

          http://bugs.adobe.com/jira/browse/SDK-21722

          http://bugs.adobe.com/jira/browse/SDK-21675

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/flex4/defaults.css

          flex/sdk/trunk/frameworks/projects/flex4/src/Flex4Classes.as

          flex/sdk/trunk/frameworks/projects/flex4/src/fl/video/VideoPlayer.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/DropDownList.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/VideoPlayer.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/primitives/VideoElement.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerSkin.mxml

          flex/sdk/trunk/frameworks/projects/framework/src/mx/events/FlexEvent.as

          flex/sdk/trunk/frameworks/projects/wireframe/defaults.css

          flex/sdk/trunk/frameworks/projects/wireframe/src/WireframeClasses.as

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerSkin.mx ml

          flex/sdk/trunk/frameworks/spark-manifest.xml

       

      Added Paths:

      ***********

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/mediaClasses/

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/mediaClasses/MuteButton.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/mediaClasses/ScrubBar.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/mediaClasses/StreamItem.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/mediaClasses/StreamingVideo Source.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/mediaClasses/VolumeBar.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/ FullScreenButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/ MuteButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/ PlayPauseButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/ ScrubBarSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/ ScrubBarThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/ ScrubBarTrackSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/ VolumeBarSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/ VolumeBarThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/fullScreen/ VolumeBarTrackSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/Full ScreenButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/Mute ButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/Play PauseButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/Scru bBarSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/Scru bBarThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/Scru bBarTrackSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/Volu meBarSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/Volu meBarThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/mediaClasses/normal/Volu meBarTrackSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/FullS creenButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/MuteB uttonSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/PlayP auseButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/Scrub BarSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/Scrub BarThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/Scrub BarTrackSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/Volum eBarSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/Volum eBarThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/Volum eBarTrackSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/fullS creen/

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/mediaClasses/fullS creen/FullScreenButtonSkin.mxml

       

      Removed Paths:

      *************

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/VideoPlayerScrubBar.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/VideoPlayerVolumeBar.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/VideoPlayerVolumeBarMuteBut ton.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/supportClasses/StreamItem.a s

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/components/supportClasses/StreamingVid eoSource.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/events/VideoPlayerVolumeBarEvent.as

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenBut tonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenFul lScreenButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenPla yPauseButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenScr ubBarSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenScr ubBarThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenScr ubBarTrackSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenVol umeBarMuteButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenVol umeBarSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenVol umeBarThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerFullScreenVol umeBarTrackSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerPlayPauseButt onSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerScrubBarSkin. mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerScrubBarThumb Skin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerScrubBarTrack Skin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerVolumeBarMute ButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerVolumeBarSkin .mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerVolumeBarThum bSkin.mxml

          flex/sdk/trunk/frameworks/projects/flex4/src/spark/skins/default/VideoPlayerVolumeBarTrac kSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerFullScr eenButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerFullScr eenFullScreenButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerPlayPau seButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerScrubBa rSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerScrubBa rThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerScrubBa rTrackSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerVolumeB arMuteButtonSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerVolumeB arSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerVolumeB arThumbSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/VideoPlayerVolumeB arTrackSkin.mxml