0 Replies Latest reply on Jun 26, 2009 8:05 AM by Paul Reilly

    [svn:fx-trunk] 8306: * A trio of compiler fixes.

    Paul Reilly Level 1

      Revision: 8306

      Author:   preilly@adobe.com

      Date:     2009-06-26 08:05:34 -0700 (Fri, 26 Jun 2009)

       

      Log Message:

      ***********

      • A trio of compiler fixes.

       

      tests Passed: checkintests

       

      Needs QA: YES, please confirm each of the bug fixes with AST

                generation on and off.

       

      Needs DOC: NO

       

      Bug fixes: SDK-20158, SDK-21871 with AST generation, SDK-21528

       

      API Change: NO

       

      Reviewer: Pete F.

       

      Cycloner: Gaurav

       

      Code-level description of changes:

       

        as3/AbstractSyntaxTreeUtil.java

       

          Modified generateMemberExpression() to handle expressions like Vector..

       

        as3/binding/DataBindingFirstPassEvaluator.java

       

          Renamed isString() to isArrayOrString() and added check for Array.

       

        mxml/lang/StandardDefs.java

       

          Added intern() to PACKAGE_FLASH_UTILS, because it's used in AST

          generation now.

       

        mxml/lang/ChildNodeHandler.java

       

          Modified invoke() to call defaultPropertyElement() even in the

          case of binding expressions.

       

        mxml/builder/ComponentBuilder.java

       

          Modified constructor to initialize bindingHandler.

       

          Added ComponentDeclarationBindingHandler inner class.

       

        mxml/builder/DocumentBuilder.java

       

          Removed ComponentDeclarationBindingHandler inner class.

       

        mxml/rep/init/ValueInitializer.java

       

          Modified formatExpr() to handle fully qualified class names when

          the targetType is functionType.

       

        mxml/gen/ClassDefLib.vm

       

          Added special case handling, equivalent to compile time singleton

          coercion, for binding source functions when the return type is

          Array.

       

        mxml/ImplementationGenerator.java

       

          AST generation equivalent to ClassDefLib.vm changes.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-20158

          http://bugs.adobe.com/jira/browse/SDK-21871

          http://bugs.adobe.com/jira/browse/SDK-21528

       

      Modified Paths:

      **************

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/AbstractSyntaxTreeUtil.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/binding/DataBindingFirstPassE valuator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/binding/TypeAnalyzer.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/ComponentBuilder.jav a

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/builder/DocumentBuilder.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/gen/ClassDefLib.vm

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/lang/ChildNodeHandler.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/lang/StandardDefs.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/init/ValueInitializer.ja va