0 Replies Latest reply on Jul 10, 2009 4:53 PM by Jason Szeto

    [svn:fx-trunk] 8520: BitmapFill and BitmapImage bug fixes

    Jason Szeto Level 3

      Revision: 8520

      Author:   jszeto@adobe.com

      Date:     2009-07-10 16:53:09 -0700 (Fri, 10 Jul 2009)

       

      Log Message:

      ***********

      BitmapFill and BitmapImage bug fixes

       

      http://bugs.adobe.com/jira/browse/SDK-17477 - only edge pixels expand when resize this bitmapGraphic

       

      If repeat mode is false, the Player will extend the edge pixels of the bitmap to fill the empty space. The fix is to limit the fill area to the size of the bitmap.

       

      http://bugs.adobe.com/jira/browse/SDK-21980 - BitmapFill repeat property behaves differently than BitmapImage

       

      If repeat mode is false, the Player will extend the edge pixels of the bitmap to fill the empty space. The fix is to draw the transformed bitmapData into a new bitmapData that is two pixels wider and taller than the source bitmap if repeat is false. There is a caching mechanism that keeps the new bitmapData around unless the source, one of the transform properties or the bounds size have changed.

       

      There is an additional optimization which only uses the extra bitmapData if it is larger than the bounds or if it has been transformed.

       

      Unfortunately this means that the BitmapFill will keep around an extra bitmapData object in certain circumstances. This situation will most frequently happen when the bitmap is smaller than the shape being filled and repeat is set to false.

       

      QE Notes: Add tests where the BitmapFill shape or BitmapImage size is larger than the bitmap itself and repeat = false

      Doc Notes: None

      Bugs: SDK-17477, SDK-21980

      Reviewer: Glenn

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-17477

          http://bugs.adobe.com/jira/browse/SDK-21980

          http://bugs.adobe.com/jira/browse/SDK-17477

          http://bugs.adobe.com/jira/browse/SDK-21980

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/BitmapFill.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/BitmapImage.as