0 Replies Latest reply on Jul 14, 2009 11:57 AM by Paul Reilly

    [svn:fx-trunk] 8553: * Fixed -dump-config, -keep-generated-signatures, and -link-report, so

    Paul Reilly Level 1

      Revision: 8553

      Author:   preilly@adobe.com

      Date:     2009-07-14 11:57:06 -0700 (Tue, 14 Jul 2009)

       

      Log Message:

      ***********

      • Fixed -dump-config, -keep-generated-signatures, and -link-report, so

        they write to the output directory when Flash Builder sets

        DEFAULT_OUTPUT_DIRECTORY_TOKEN.  Previously they were writing to the

        target file's parent directory.

       

      tests Passed: checkintests

       

      Needs QA: YES

       

      Needs DOC: YES, uses should look for generated files and directories

                 in the bin folder instead of the src folder.

       

      Bug fixes: SDK-21158

       

      API Change: NO

       

      Reviewer: Pete F.

       

      Cycloner: Gaurav

       

      Code-level description of changes:

       

        tools/CommandLineConfiguration.java

        tools/CompcConfiguration.java

       

          Modified validate() to no longer process dumpConfigFile and create

          the generated directory when -keep is true.  It's done by the

          super class.

       

          Removed getDumpConfig(), cfgDumpConfig(), getDumpConfigInfo(), and

          getOutput(), because they have been moved to the super class.

       

        tools/oem/internal/LinkerConfiguration.java

       

          Added getOutput() and getTargetFile() stubs.

       

        tools/oem/internal/ApplicationCompilerConfiguration.java

       

          Modified validate() to no longer create the generated directory

          when -keep is true.  It's done by the super class.

       

          Removed getVirtualFile(), because it's no longer used.

       

          Added getOutput().

       

        tools/ASDocConfiguration.java

       

          Modified validate() to no longer create the generated directory

          when -keep is true.  It's done by the super class.

       

          Added getTargetFile() stub.

       

        tools/ToolsConfiguration.java

       

          Added getOutput(), abstract getTargetFile(),

          createOutputDirectory(), validateDumpConfig(),

          validateKeepGeneratedSignatures(),

          validateKeepGeneratedActionScript(), getDumpConfig(),

          cfgDumpConfig(), and getDumpConfigInfo().

       

          Modified validate() to call alidateDumpConfig(),

          validateKeepGeneratedSignatures(), and

          validateKeepGeneratedActionScript().

       

        tools/flexbuilder/BuilderApplication.java

        tools/flexbuilder/BuilderLibrary.java

       

          Removed -dump-config from the excludes list.

       

        compiler/common/CompilerConfiguration.java

       

          Modified setSignatureDirectory() to just set the

          signatureDirectory.

       

          Modified cfgSignatureDirectory() to check the

          DEFAULT_OUTPUT_DIRECTORY_TOKEN first, then default to the "."

          directory.

       

        compiler/common/Configuration.java

       

          Modified getOutputPath() to check DEFAULT_OUTPUT_DIRECTORY_TOKEN

          first.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-21158

       

      Modified Paths:

      **************

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/common/CompilerConfiguration.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/common/Configuration.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/ASDocConfiguration.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/CommandLineConfiguration.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/CompcConfiguration.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/ToolsConfiguration.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/flexbuilder/BuilderApplication.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/flexbuilder/BuilderLibrary.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/oem/internal/ApplicationCompilerConf iguration.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/oem/internal/LinkerConfiguration.jav a