0 Replies Latest reply on Jul 15, 2009 11:20 AM by deepa subramaniam (adobe)

    [svn:fx-trunk] 8589: With this check-in, we now collapse Path segment classes (PathSegment, MoveSegment, LineSegment, CloseSegment, CubicBezierSegment, QuadraticBezierSegment) as internal, private classes in Path.

    deepa subramaniam (adobe) Level 2

      Revision: 8589

      Author:   dsubrama@adobe.com

      Date:     2009-07-15 11:20:12 -0700 (Wed, 15 Jul 2009)

       

      Log Message:

      ***********

      With this check-in, we now collapse Path segment classes (PathSegment, MoveSegment, LineSegment, CloseSegment, CubicBezierSegment, QuadraticBezierSegment) as internal, private classes in Path. Paths will now be wholly dependent on the compact syntax for expressing Path data. Previously, users could write:

       

       

       

      Additional changes include:

       

      1. Path.segments property removed. In its place, there is private variable (segments) which holds the path data parsed into the correct segment objects. 

       

      2. Path.segmentChanged() removed ?\226?\128?\147 Segments do not need to notify the parent path when their properties have changed since they are now not individually accessible.

       

      3. PathSegment.segmentHost property removed ?\226?\128?\147 Segments do not need a pointer back to the parent Path since now they are now not individually accessible.

       

      4. PathSegment.notifySegmentChanged() removed ?\226?\128?\147 Segments do not need to notify the parent Path they have changed since they are now not individually accessible.

       

      5. PathSegment.dispatchSegmentChanged() removed ?\226?\128?\147 Path segments do not need to dispatch propertyChange events since they are now not individually accessible. As part of this, I have removed the and       metadata from all PathSegment properties.

       

      6. PathSegment no longer extends EventDispatcher, instead it extends Object.

       

      7. All of the PathSegment and derivative classes no longer have getters/setters for their properties (like x, y, etc) since these properties are now not dispatching property change events.

       

      8. A variety of checkintests/sparkTest project files have been updated to use the compact syntax as they are drawn/transitioned between state changes. Refer to sparkTest/AddItemsTest.mxml and RemoveItemsTest.mxml for examples on how to use states and transitions to transform Paths through the data they are bound to (as opposed to modifying individual segments).

       

      This is as per the ARB decision listed here: http://opensource.adobe.com/wiki/display/flexsdk/VerbosePathSyntax

       

      QA: Yes - Joan ran a cyclone and updated all tests

      Doc: Yes - Changes above need to be reflected in documentation

      Checkintests: Pass

       

      Modified Paths:

      **************

          flex/sdk/trunk/development/eclipse/flex/sparkTest/src/AddItemsTest.mxml

          flex/sdk/trunk/development/eclipse/flex/sparkTest/src/EffectsProperties.mxml

          flex/sdk/trunk/development/eclipse/flex/sparkTest/src/RemoveItemsTest.mxml

          flex/sdk/trunk/frameworks/fxg-manifest.xml

          flex/sdk/trunk/frameworks/projects/spark/asdoc/en_US/spark/primitives/examples/ArrowExamp le.mxml

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/Path.as

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/ScrollBarDownButto nSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/ScrollBarLeftButto nSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/ScrollBarRightButt onSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/ScrollBarUpButtonS kin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/SpinnerDecrementBu ttonSkin.mxml

          flex/sdk/trunk/frameworks/projects/wireframe/src/spark/skins/wireframe/SpinnerIncrementBu ttonSkin.mxml

          flex/sdk/trunk/frameworks/spark-manifest.xml

          flex/sdk/trunk/frameworks/tests/states/statefulNodes.mxml

       

      Removed Paths:

      *************

          flex/sdk/trunk/frameworks/projects/spark/asdoc/en_US/spark/primitives/examples/CircleExam ple.mxml

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/pathSegments/CloseSegment.a s

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/pathSegments/CubicBezierSeg ment.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/pathSegments/LineSegment.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/pathSegments/MoveSegment.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/pathSegments/PathSegment.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/pathSegments/QuadraticBezie rSegment.as