0 Replies Latest reply on Jul 31, 2009 8:04 AM by Carol L. Frampton

    [svn:fx-trunk] 8953: Per the signoff, removed the debug code from RET.

    Carol L. Frampton Level 2

      Revision: 8953

      Author:   cframpto@adobe.com

      Date:     2009-07-31 08:03:43 -0700 (Fri, 31 Jul 2009)

       

      Log Message:

      ***********

      Per the signoff, removed the debug code from RET.

       

      SDK-22385.  Programatically giving focus to RET should work correctly now.

       

      SDK-22384.  RET implements IFocusManagerComponent now so you can tab into one.

       

      SDK-22391.  Fixed an autoSize bug in updateDisplayList().

       

      Reworked the textFlow getter which wasn't quite right if there were uncommitted properties.

       

      Change the selection behavior on focusIn to be consistent with Halo with one exception.  The focusIn behavior is still subject to change but this is closer to final than what we have now.

       

      As of this change, on focusIn, if there is no selection, if multiline (ie TextArea and RET), the insertion pt is set to 0,0, and if !multiline (ie TextInput) all the text is selected.  If the text/textFlow is set while the component already has focus the insertion pt is set to 0,0 (for ex. NumericStepper clicking up or down arrow).

       

      The only remaining difference I know of between spark and halo is for TextInput.  halo TextInput on focusIn only remembers the previous selection, whether set programatically or with the mouse, if a selection was programatically set at some point.  spark TextInput will remember a previous selection regardless of how it was set.  The halo behavior doesn't make sense to me but we may end up changing spark to match.

       

      QE notes: since the focusIn change didn't break any TextArea/TextInput tests that means we don't have any

      Doc notes:

      Bugs: SDK-22385, SDK-22384, SDK-22391

      Reviewer: Gordon

      Tests run: mustella TextInput TextArea passed NumericStepper 2 failures because insertion pt is now 0,0 rather than end of text

      Is noteworthy for integration: RET is now focusable with tab or programatically with setFocus(), insertion point on focusIn changes

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-22385

          http://bugs.adobe.com/jira/browse/SDK-22384

          http://bugs.adobe.com/jira/browse/SDK-22391

          http://bugs.adobe.com/jira/browse/SDK-22385

          http://bugs.adobe.com/jira/browse/SDK-22384

          http://bugs.adobe.com/jira/browse/SDK-22391

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTex tBase.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/RichEditableText.as