0 Replies Latest reply on Aug 19, 2009 8:55 AM by Carol L. Frampton

    [svn:fx-trunk] 9385: SkinnableTextBase. as - remove code to redispatch UPDATE_COMPLETE event from RET.

    Carol L. Frampton Level 2

      Revision: 9385

      Author:   cframpto@adobe.com

      Date:     2009-08-19 08:54:55 -0700 (Wed, 19 Aug 2009)

       

      Log Message:

      ***********

      SkinnableTextBase.as - remove code to redispatch UPDATE_COMPLETE event from RET.  For each property setter, even though they are just proxies to RET, call invalidateProperties() to generate UPDATE_COMPLETE events and add handler for the TextOperationEvent.CHANGE and call invalidateDisplayList() to generate UPDATE_COMPLETE events for RET size and display list changes.  SDK-22705

       

      TextArea.as - remove code to set scroller horizontalScrollPosition to off if "toFit".  Need to do it "virtually" rather than actually change the scroller property.  SDK-22680

       

      RichEditableText.as

      Changes to rememasureText() and measure() since not all combinations of constrainted width/height worked correctly, particularly if auto sizing.  SDK-22727

      Changes to textContainerManager_compositionCompleteHandler() to try to keep "contentWidth" seen by scroller constant if lineBreak="toFit" so the scroller doesn't think it needs to add a horizontal scroll bar.  If the text is "toFit" there should never be a hsb.  SDK-22680

      Change to updateDisplayList() to scroll after updating the container if it was delayed when EditManager.updateAllContainers() last ran. SDK-22705

      Removed default params from scrollToRange() since they don't make sense.  SDK-22696.

      Some cleanup based on TLF cleanup.

       

      RichEditableTextContainerManager.as - in drawBackgroundAndSetScrollRect(), if auto sizing, should use the display list width and height for the scroll rect and background for the text rather than the content width and height.   SDK-22727 and SDK-22678 ended up fixed too.

       

      RichEditableTextEditManager.as - flag to know if scroll is needed after updating the container in updateDisplayList.  SDK-22696

       

      QE notes: be sure to make automated tests for SDK-22727, SDK-22705, SDK-22678 please

      Doc notes:

      Bugs: SDK-22727, SDK-22626, SDK-22680, SDK-22705, SDK-22696, SDK-22678

      Reviewer: Gordon

      Tests run: basictests, checkintests, TextArea, TextInput, NumericSteeper

      Is noteworthy for integration: no

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-22705

          http://bugs.adobe.com/jira/browse/SDK-22680

          http://bugs.adobe.com/jira/browse/SDK-22727

          http://bugs.adobe.com/jira/browse/SDK-22680

          http://bugs.adobe.com/jira/browse/SDK-22705

          http://bugs.adobe.com/jira/browse/SDK-22696

          http://bugs.adobe.com/jira/browse/SDK-22727

          http://bugs.adobe.com/jira/browse/SDK-22678

          http://bugs.adobe.com/jira/browse/SDK-22696

          http://bugs.adobe.com/jira/browse/SDK-22727

          http://bugs.adobe.com/jira/browse/SDK-22705

          http://bugs.adobe.com/jira/browse/SDK-22678

          http://bugs.adobe.com/jira/browse/SDK-22727

          http://bugs.adobe.com/jira/browse/SDK-22626

          http://bugs.adobe.com/jira/browse/SDK-22680

          http://bugs.adobe.com/jira/browse/SDK-22705

          http://bugs.adobe.com/jira/browse/SDK-22696

          http://bugs.adobe.com/jira/browse/SDK-22678

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/TextArea.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableTex tBase.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/RichEditableText.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/supportClasses/RichEditable TextContainerManager.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/supportClasses/RichEditable TextEditManager.as