0 Replies Latest reply on Sep 2, 2009 1:52 PM by Paul Reilly

    [svn:fx-trunk] 9936: * Defer CSS Embed(), ClassReference(), and PropertyReference()

    Paul Reilly

      Revision: 9936

      Author:   preilly@adobe.com

      Date:     2009-09-02 13:52:24 -0700 (Wed, 02 Sep 2009)

       

      Log Message:

      ***********

      • Defer CSS Embed(), ClassReference(), and PropertyReference()

        handling until code generation time, so that we only process styles

        after overrides have been applied.

       

      QE notes: existing tests should pass

      Doc notes: N/A

      Bugs: SDK-22659

      Reviewer: Corey

      Tests run: "mxunit atembed"

      Is noteworthy for integration: Yes, needed for the MX-only feature

      Code-level description of changes:

       

        flex2/tools/PreLink.java

       

          Modified backgroundColor and styleName handling by wrapping it

          with a check for a value of type String.

       

        flex2/compiler/css/StyleModule.java

       

          Modified getAtEmbeds() to return the atEmbeds from each StyleDef.

       

        flex2/compiler/css/StyleDef.java

       

          Removed atEmbeds and imports.

       

          Modified getAtEmbeds() and getImports() to collect the result from

          the StyleProperties dynamically.

       

          Removed addAtEmbed() and processEmbed().

       

          Modified processPropertyValue() to return an Object instead of a

          String.

       

        flex2/compiler/mxml/rep/AtEmbed.java

       

          Added equals(), hashCode(), and toString().

       

        flex2/compiler/mxml/rep/MxmlDocument.java

       

          Modified getAtEmbeds() to add the atEmbeds from the

          StylesContainer dynamically to the result.

       

        flash/css/StyleProperty.java

       

          Changed value from a String to an Object, so we can support

          String, AtEmbed, and Reference.

       

        flex2/compiler/css/Reference.java

       

          Initial checkin.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-22659

       

      Modified Paths:

      **************

          flex/sdk/trunk/modules/compiler/src/java/flash/css/StyleProperty.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/css/StyleDef.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/css/StyleModule.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/AtEmbed.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocument.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/PreLink.java

       

      Added Paths:

      ***********

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/css/Reference.java