0 Replies Latest reply on Sep 8, 2009 6:02 PM by rfrishbe

    [svn:fx-trunk] 10075: Cleanups from the spark text changes and some bug fixes for VideoElement.

    rfrishbe Level 3

      Revision: 10075

      Author:   rfrishbe@adobe.com

      Date:     2009-09-08 18:01:58 -0700 (Tue, 08 Sep 2009)

       

      Log Message:

      ***********

      Cleanups from the spark text changes and some bug fixes for VideoElement.  Also some PARB changes for UIComponent.

       

      TitleBar: Changing the skin part type from Label to Textbase

       

      UIComponent: skipMeasure()->canSkipMeasurement() to be in line with GraphicElement.  This has been PARB approved.

      UIComponent: same with hasComplexLayoutMatrix...this replaces hasDeltaIdentityTransform.  This has been PARB approved.

       

      StyleProtoChain: cleanup around what interfaces to use

       

      TextBase: clean up code that?\226?\128?\153s no longer needed.

       

      VideoElement: Fixing 4 bugs:

      SDK-22824: sourceLastPlayed keeps track of what video file we?\226?\128?\153ve called play() with last.  This way if a user pauses the video and wants to start it up again at the same point, we can call play(null) on the underlying FLVPlayback videoPlayer.  However, anytime the souce changes, we want to null out sourceLastPlayed.  This was causing a bug when someone set the source to null and then reset it to it?\226?\128?\153s previous value.

       

      SDK-23034 (GUMBO_PRIORITY): This deals with some FLVPlayback quirks around sizing.  I had put in a fix so we weren?\226?\128?\153t setting width/height on the underlying videoPlayer too many times, but apparently we need to make sure it always gets called once.  Hopefully when switching to Strobe we can cleanup this logic...I put a FIXME in to do this.

       

      SDK-21947/ SDK-22533 - some video files don?\226?\128?\153t always send out a metadata event.  I?\226?\128?\153m not quite sure why this is, but in case this happens, we do a check in the ready handler to see whether we should call invalidateSize() to make sure it gets sized properly.

       

      QE notes:-

      Doc notes:-

      Bugs: SDK-22824, SDK-23034, SDK-21947, SDK-22533

      Reviewer: Glenn, Corey

      Tests run: checkintests, Button, GraphicTags, VideoElement, and VideoPlayer (some VideoPlayer were failing, but I think it should be fine)

      Is noteworthy for integration: Yes

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-22824

          http://bugs.adobe.com/jira/browse/SDK-23034

          http://bugs.adobe.com/jira/browse/SDK-21947

          http://bugs.adobe.com/jira/browse/SDK-22533

          http://bugs.adobe.com/jira/browse/SDK-22824

          http://bugs.adobe.com/jira/browse/SDK-23034

          http://bugs.adobe.com/jira/browse/SDK-21947

          http://bugs.adobe.com/jira/browse/SDK-22533

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/airframework/src/spark/components/windowClasses/TitleB ar.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/core/UIComponent.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/styles/StyleProtoChain.as

          flex/sdk/trunk/frameworks/projects/spark/src/mx/core/UITLFTextField.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/Group.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/Label.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/RichEditableText.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/RichText.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/GroupBase.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/Skin.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/supportClasses/TextBase.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/effects/supportClasses/AddActionInstan ce.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/effects/supportClasses/AnimateTransfor mInstance.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/effects/supportClasses/RemoveActionIns tance.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/VideoElement.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/supportClasses/GraphicEleme nt.as