0 Replies Latest reply on Sep 11, 2009 8:09 AM by Paul Reilly

    [svn:fx-trunk] 10154: * Two beta 2 fixes.

    Paul Reilly Level 1

      Revision: 10154

      Author:   preilly@adobe.com

      Date:     2009-09-11 08:09:18 -0700 (Fri, 11 Sep 2009)

       

      Log Message:

      ***********

      • Two beta 2 fixes.

       

      QE notes: We should add a "mxunit databinding" test case for

                SDK-21101.  It might require checking that the watchers are

                correct, because due to RTTI the data binding happens to

                work at runtime even though we didn't handle "as"

                expressions correctly before.

      Doc notes:

      Bugs: SDK-21101, SDK-22549

      Reviewer: Corey

      Tests run: checkintests, mxunit databinding

      Is noteworthy for integration: No

      Code-level description of changes:

       

        as3/binding/DataBindingFirstPassEvaluator.java

       

          This fix adds support for data binding expressions like:

       

            {(foo as Bar).baz}

       

          by modifying evaluate(Context, BinaryExpression) to not reset the

          watchList when the op is AS_TOKEN and by modifying getRef() by

          adding support for MemberExpressionNode's with a

          BinaryExpressionNode base, which happens to be contained within a

          ListNode.

       

        mxml/ImplementationGenerator.java

       

          Modified generateBindingExprsFunction() by removing the casting to

          an ExpressionStatementNode when we parse a destination string from

          a Binding tag.  If the destination is valid, it should be an

          ExpressionStatementNode, but if the string contains invalid AS

          code, it might not be, so this fix allows ASC to handle the

          invalid AS code downstream.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-21101

          http://bugs.adobe.com/jira/browse/SDK-21101

          http://bugs.adobe.com/jira/browse/SDK-22549

       

      Modified Paths:

      **************

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/binding/DataBindingFirstPassE valuator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java