0 Replies Latest reply on Sep 11, 2009 3:15 PM by Chet Haase

    [svn:fx-trunk] 10173: Third time's a charm.

    Chet Haase Level 3

      Revision: 10173

      Author:   chaase@adobe.com

      Date:     2009-09-11 15:15:30 -0700 (Fri, 11 Sep 2009)

       

      Log Message:

      ***********

      Third time's a charm. This is a fix for the checkbox/radiobutton bug where halo components with spark skins were not positioning the icons correctly when the components had no label. The fix is to always make room (vertically) for a label, whether it is there or not. This allows these controls to align nicely with other labeled versions of those controls. It will break some Mustella tests that assign a smaller vertical height.

      Note that the earlier attempt at this fix applied the vertical adjustment to all halo components, even when running with the halo theme. This new version restricts the fix to only halo components running with the spark theme (which is where the problem was to begin with, since the adjustment is necessary due to the different padding styles in spark skins). So only halo components with spark skins should be affected by this change.

       

      QE notes: Breakage in Checkbox and globalization Mustella tests due to larger vertical size of CheckBox and RadioButton. (updates have been made and will follow this checkin)

      Doc notes: None

      Bugs: SDK-21850

      Reviewer: Glenn

      Tests run: checkintests, Mustella components/CheckBox components/RadioButton

      Is noteworthy for integration: No

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-21850

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/CheckBox.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/RadioButton.as

          flex/sdk/trunk/tools/dependencychecker/frameworkSwcExceptionsList.txt