0 Replies Latest reply on Sep 11, 2009 5:10 PM by Jason Szeto

    [svn:fx-trunk] 10189: Panel cornerRadius bug fixes

    Jason Szeto Level 3

      Revision: 10189

      Author:   jszeto@adobe.com

      Date:     2009-09-11 17:10:25 -0700 (Fri, 11 Sep 2009)

       

      Log Message:

      ***********

      Panel cornerRadius bug fixes

       

      http://bugs.adobe.com/jira/browse/SDK-23018 - Setting larger cornerRadius values for Panel causes some strange rendering

      http://bugs.adobe.com/jira/browse/SDK-23015 - Setting cornerRadius for Panel with controlBar does not get applied well

       

      The issue occurs when the cornerRadius is bigger than half the height of the titleBar or controlBar. Rect won't extend the corner beyond halfway down a side. (If it did, you'd get some strange artifacts if both corners of a side are rounded.)

       

      The solution is to use a mask which is the size of the background fill. Masks are applied to the top and bottom chrome. I removed the cornerRadius properties from all of the skin parts inside the content layer since the mask will now take care of the rounded corners. Using the mask also solves the problem of the titleBar divider bleeding out the sides with a big cornerRadius.

       

      I have also updated the Spark mx Panel skin.

       

      QE notes: Add cornerRadius tests

      Doc notes: No

      Bugs: SDK-23015, SDK-23018

      Reviewer: Glenn

      Tests run: gumbo/components/Panel, containers

      Is noteworthy for integration: No

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-23018

          http://bugs.adobe.com/jira/browse/SDK-23015

          http://bugs.adobe.com/jira/browse/SDK-23015

          http://bugs.adobe.com/jira/browse/SDK-23018

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/PanelSkin.mxml

          flex/sdk/trunk/frameworks/projects/sparkskins/src/mx/skins/spark/PanelBorderSkin.mxml