0 Replies Latest reply on Sep 12, 2009 3:08 PM by Jason Szeto

    [svn:fx-trunk] 10202: http://bugs.adobe.com/jira/browse/ SDK-23127 - ItemRenderers in a List don' t have rounded corners anymore even if the Halo theme is used

    Jason Szeto Level 3

      Revision: 10202

      Author:   jszeto@adobe.com

      Date:     2009-09-12 15:08:24 -0700 (Sat, 12 Sep 2009)

       

      Log Message:

      ***********

      http://bugs.adobe.com/jira/browse/SDK-23127 - ItemRenderers in a List don't have rounded corners anymore even if the Halo theme is used

       

      We recently modified the defaults.css stylesheet with different cornerRadius values. A cornerRadius of 0 was added to the ScrollControlBase type selector. List passes its styles directly to the renderers via the styleName mechanism. When a button is used as an itemRenderer, its cornerRadius value was overridden by ScrollControlBase's cornerRadius value.

       

      The fix is to remove cornerRadius from the ScrollControlBase type selector. To resolve the side effect of the focus rect having rounded corners, I have added focusRoundedCorners with a value of " " to the ScrollControlBase type selector for the frameworks project. This will force the focusSkin to ignore the rounded corners.

       

      For the Halo mx skins styleSheet, I override the ScrollControlBase focusRoundedCorners style to enabled the focusSkin to have rounded corners since Halo supports cornerRadius on List.

       

      Note that List and ScrollControlBase will still have a cornerRadius of 2, even though the Spark mx skins don?\226?\128?\153t support cornerRadius. Visually, however, they will not have any cornerRadius.

       

      QE notes: None

      Doc notes: None

      Bugs: SDK-23127

      Reviewer: Glenn

      Tests run: components/List

      Is noteworthy for integration: No

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-23127

          http://bugs.adobe.com/jira/browse/SDK-23127

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/framework/defaults.css

          flex/sdk/trunk/frameworks/projects/halo/defaults.css