0 Replies Latest reply on Sep 15, 2009 10:54 AM by Paul Reilly

    [svn:fx-trunk] 10270: * A beta 2 fix.

    Paul Reilly Level 1

      Revision: 10270

      Author:   preilly@adobe.com

      Date:     2009-09-15 10:54:40 -0700 (Tue, 15 Sep 2009)

       

      Log Message:

      ***********

      • A beta 2 fix.

       

      QE notes:

      Doc notes:

      Bugs: SDK-21830

      Reviewer: Corey

      Cycloner: Gaurav

      Tests run: checkintests

      Is noteworthy for integration: no

      Code-level description of changes:

       

        frameworks/tests/basicTests/halo/views/CollectionTests.mxml

       

          Removed extra curly brace found by running without direct AST

          generation.  I'll be logging a bug for this.

       

        modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocument.java

       

          Modified getDescriptorDeclaration() to use new

          DescriptorGenerator.addDescriptorInitializerFragments() signature.

       

        modules/compiler/src/java/flex2/compiler/mxml/rep/init/ValueInitializer.java

       

          Modified getDefinitionBody() to use new

          DescriptorGenerator.addDescriptorInitializerFragments() signature

          and pass in an empty Set for the properties to include.  This

          outputs only the children, which is what we want.

       

          Modified generateDefinitionBody() to do the direct AST generation

          equivalent.

       

        modules/compiler/src/java/flex2/compiler/mxml/gen/DescriptorGenerator.java

       

          Renamed getDescriptorInitializerFragments() to

          addDescriptorInitializerFragments() and added list,

          includeDesignLayer, and indent parameters to allow more control

          over the output.

       

        modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

       

          Modified generateBindingsSetupFunction() to call

          generateTwoWayPrimaryAssignment() and added

          generateTwoWayPrimaryAssignment().

       

          Modified addDescriptorInitializerFragments() and

          addDescriptorProperties() by adding an includeDesignLayer

          parameter.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-21830

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/tests/basicTests/halo/views/CollectionTests.mxml

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/gen/DescriptorGenerator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocument.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/init/ValueInitializer.ja va