0 Replies Latest reply on Sep 21, 2009 10:40 AM by Paul Reilly

    [svn:fx-gumbo_beta2] 10463: * Fixed the widely reported:

    Paul Reilly Level 1

      Revision: 10463

      Author:   preilly@adobe.com

      Date:     2009-09-21 10:39:59 -0700 (Mon, 21 Sep 2009)

       

      Log Message:

      ***********

      • Fixed the widely reported:

       

         java.lang.NullPointerException

           at flex2.tools.PreLink.locateStyleDefaults(PreLink.java:148)

       

      QE notes:

      Doc notes:

      Bugs: SDK-23199, SDK-20233, FB-22919, SDK-21310, and SDK-17952

      Reviewer: Corey

      Cycloner: Gaurav

      Tests run: Flash Builder JUnit AllProjectTestsSmokesSuite, full SDK cyclone

      Is noteworthy for integration: Yes fixes issues in Flash Builder JUnit tests

      Code-level description of changes:

       

        modules/compiler/src/java/flex2/tools/PreLink.java

       

          Moved StylesContainer validation to postRun(), so that it only

          happens once per compilation.  This required passing in the

          SymbolTable and NameMappings.

       

          Modified run() to only create a global StylesContainer if one

          hasn't been created.

       

        modules/compiler/src/java/flex2/tools/CompcPreLink.java

       

          Updated postRun() to new signature.

       

        modules/compiler/src/java/flex2/compiler/PreLink.java

       

          Modified postRun() signature by adding SymbolTable and

          NameMappings args.

       

        modules/compiler/src/java/flex2/compiler/CompilerAPI.java

       

          Updated compiler to use the new postRun() signature.

       

        modules/compiler/src/java/flex2/compiler/css/StylesContainer.java

       

          Removed StylesContainer(CompilationUnit, ContextStatics,

          MxmlConfiguration) constructor.

       

          Renamed checkForUnusedTypeSelectors() to validate().

       

        modules/compiler/src/java/flex2/compiler/SymbolTable.java

       

          Added getClassNames() for use by StylesContainer.validate().

       

        modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocument.java

       

          Modified constructor to set the CompilationUnit's StylesContainer.

       

        modules/compiler/src/java/flex2/compiler/mxml/MxmlCompiler.java

       

          Made TYPE_TABLE public, so the css package can share the TypeTable

          rather than create a new one.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-23199

          http://bugs.adobe.com/jira/browse/SDK-20233

          http://bugs.adobe.com/jira/browse/FB-22919

          http://bugs.adobe.com/jira/browse/SDK-21310

          http://bugs.adobe.com/jira/browse/SDK-17952

       

      Modified Paths:

      **************

          flex/sdk/branches/gumbo_beta2/modules/compiler/src/java/flex2/compiler/CompilerAPI.java

          flex/sdk/branches/gumbo_beta2/modules/compiler/src/java/flex2/compiler/PreLink.java

          flex/sdk/branches/gumbo_beta2/modules/compiler/src/java/flex2/compiler/SymbolTable.java

          flex/sdk/branches/gumbo_beta2/modules/compiler/src/java/flex2/compiler/css/StylesContaine r.java

          flex/sdk/branches/gumbo_beta2/modules/compiler/src/java/flex2/compiler/mxml/MxmlCompiler. java

          flex/sdk/branches/gumbo_beta2/modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocum ent.java

          flex/sdk/branches/gumbo_beta2/modules/compiler/src/java/flex2/tools/CompcPreLink.java

          flex/sdk/branches/gumbo_beta2/modules/compiler/src/java/flex2/tools/PreLink.java