0 Replies Latest reply on Sep 28, 2009 11:22 AM by Paul Reilly

    [svn:fx-trunk] 10647: * A batch of compiler fixes.

    Paul Reilly Level 1

      Revision: 10647

      Author:   preilly@adobe.com

      Date:     2009-09-28 10:21:59 -0700 (Mon, 28 Sep 2009)

       

      Log Message:

      ***********

      • A batch of compiler fixes.

       

      QE notes:

      Doc notes:

      Bugs: SDK-22258, SDK-21547, SDK-22879, SDK-23169, SDK-23336

      Reviewer: Edwin (ActionFactory.java), Ryan (VideoPlayer.as), Corey

      Tests run: full cyclone

      Is noteworthy for integration: Yes, HostComponent, SkinPart, and

                                     SkinState metadata is now validated by

                                     the compiler.

      Code-level description of changes:

       

        frameworks/projects/spark/src/spark/skins/spark/BorderSkin.as

       

          Made HostComponent fully qualified.

       

        frameworks/projects/spark/src/spark/components/VideoPlayer.as

       

          Updated SkinState metadata to reflect revision 7732.

       

        modules/swfutils/src/java/flash/swf/ActionFactory.java

       

          Made getLabel() more bullet proof.

       

        modules/compiler/src/java/flex2/compiler_en.properties

       

          Added as3.HostComponentExtension.HostComponentClassNotFound,

          as3.HostComponentExtension.MissingSkinPart,

          as3.HostComponentExtension.MissingSkinState,

          as3.SyntaxTreeEvaluator.OnlyOneHostComponentAllowed, and

          as3.SyntaxTreeEvaluator.SkinPartsMustBePublic.

       

        modules/compiler/src/java/flex2/compiler/CompilationUnit.java

       

          Replaced hasHostComponentMD with hostComponentMetaData.

       

        modules/compiler/src/java/flex2/compiler/as3/genext/GenerativeClassInfo.java

       

          Modified getImports() to support Vectors.

       

        modules/compiler/src/java/flex2/compiler/as3/HostComponentEvaluator.java

       

          Removed, because we really don't need to evaluate the AST again to

          find the HostComponent metadata since SyntaxTreeEvaluator has

          already found it.

       

        modules/compiler/src/java/flex2/compiler/as3/AbstractSyntaxTreeUtil.java

       

          Modified generateTypeExpression() and generateVariable() to

          support passing in a position.

       

        modules/compiler/src/java/flex2/compiler/as3/SyntaxTreeEvaluator.java

       

          Modified evaluate(Context, MetaDataNode) to handle .

       

          Modified processHostComponentMetaData() to store the node in the

          CompilationUnit and report an error if more than one HostComponent

          is found.

       

          Added processSkinPartMetaData().

       

        modules/compiler/src/java/flex2/compiler/as3/HostComponentExtension.java

       

          Refactored to handle what HostComponentEvaluator was doing, plus

          validate HostComponent, SkinPart and SkinState metadata.

       

        modules/compiler/src/java/flex2/compiler/mxml/rep/init/ValueInitializer.java

       

          Modified generateDefinitionBody() to store a line number mapped

          position for the variable definition.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-22258

          http://bugs.adobe.com/jira/browse/SDK-21547

          http://bugs.adobe.com/jira/browse/SDK-22879

          http://bugs.adobe.com/jira/browse/SDK-23169

          http://bugs.adobe.com/jira/browse/SDK-23336

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/VideoPlayer.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/BorderSkin.as

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/CompilationUnit.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/AbstractSyntaxTreeUtil.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/HostComponentExtension.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/SyntaxTreeEvaluator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/genext/GenerativeClassInfo.ja va

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/init/ValueInitializer.ja va

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler_en.properties

          flex/sdk/trunk/modules/swfutils/src/java/flash/swf/ActionFactory.java

       

      Removed Paths:

      *************

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/HostComponentEvaluator.java