0 Replies Latest reply on Oct 2, 2009 11:42 AM by Jason Szeto

    [svn:fx-trunk] 10828: FXG stroke and fill translation fix

    Jason Szeto Level 3

      Revision: 10828

      Author:   jszeto@adobe.com

      Date:     2009-10-02 10:41:48 -0700 (Fri, 02 Oct 2009)

       

      Log Message:

      ***********

      FXG stroke and fill translation fix

       

      http://bugs.adobe.com/jira/browse/SDK-23257 - Gradient translation should occur from 0,0, not the upper left bounds

       

      The current API only passes in the shape's bounds. I have added a new targetOrigin parameter to IFill.begin, IStroke.apply and IStroke.createGraphicsStroke of type Point. It is the origin (0,0) of the shape in the target graphic's coordinate space.

       

      Changed the logic in the gradient stroke and fills. The x and y transform properties are now positioned relative to the origin instead of to the top left corner of the bounds. If no x and y are set, then the default behavior remains the same.

       

      Removed the centering logic in LinearGradientStroke when scaleX was set.

       

      This API change has been approved by PARB.

       

      QE notes: Need to add tests that exercise this logic

      Doc notes: Need to document additions to the API

      Bugs: SDK-23257

      Reviewer: Deepa

      Tests run: spark/primitives, gumbo/components

      Is noteworthy for integration: Yes, modifications to the API

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-23257

          http://bugs.adobe.com/jira/browse/SDK-23257

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/BitmapFill.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/GradientStroke.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/IFill.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/IStroke.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/LinearGradient.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/LinearGradientStroke.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/RadialGradient.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/RadialGradientStroke.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/SolidColor.as

          flex/sdk/trunk/frameworks/projects/framework/src/mx/graphics/SolidColorStroke.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/Line.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/Path.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/supportClasses/FilledElemen t.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/supportClasses/StrokedEleme nt.as