0 Replies Latest reply on Oct 27, 2009 8:05 AM by Paul Reilly

    [svn:fx-trunk] 11179: * Weekly batch of compiler fixes.

    Paul Reilly Level 1

      Revision: 11179

      Author:   preilly@adobe.com

      Date:     2009-10-27 08:05:06 -0700 (Tue, 27 Oct 2009)

       

      Log Message:

      ***********

      • Weekly batch of compiler fixes.

       

      QE notes:

      Doc notes:

      Bugs: SDK-23111, SDK-23262, SDK-17908, SDK-21737, SDK-23559

      Reviewer: Corey

      Tests run: full cyclone

      Is noteworthy for integration: no

      Code-level description of changes:

       

        frameworks/projects/framework/src/mx/binding/utils/ChangeWatcher.as

       

          Added isExecuting logic to prevent infinite recursion with two way

          bindings.  We have a check in the Bindable generated setter, but

          it fails, because "NaN !== NaN" is returning true.  Go figure.

       

        modules/swfutils/src/java/flash/util/StringUtils.java

       

          Tweaked formatString() to handle unicode characters and added

          unformatString() to do the opposite for direct AST generation.

       

        modules/compiler/src/java/flex2/compiler/Source.java

       

          Added shortName arg to the constructor used by the

          InterfaceCompiler for inline components.

       

        modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocument.java

       

          Modified completeTwoWayBindings() to ensure the destination is

          Bindable.

       

        modules/compiler/src/java/flex2/compiler/mxml/rep/init/ValueInitializer.java

       

          Modified "Node formatExpr()" to use StringUtils.unformatString()

          to mimic what ASC's scanner would have done if it had read in the

          value.

       

        modules/compiler/src/java/flex2/compiler/mxml/InterfaceCompiler.java

       

          Modified addExcludeClassNode() to no longer set the line and

          column for the inlineExcludeNode and excludeTextNode, so they

          don't have warnings and errors reported for them.  I guess no one

          compiles the frameworks with -keep.  Otherwise, this would have

          blocked them.

       

          Modified createInlineComponentUnit() and createDefinitionUnit() to

          pass in the className, as the shortName, to the Source

          constructor.

       

        modules/antTasks/src/flex/ant/MxmlcTask.java

        modules/antTasks/src/flex/ant/CompcTask.java

        modules/antTasks/src/flex/ant/AsDocTask.java

       

          Added support for show-invalid-css-property-warnings option.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-23111

          http://bugs.adobe.com/jira/browse/SDK-23262

          http://bugs.adobe.com/jira/browse/SDK-17908

          http://bugs.adobe.com/jira/browse/SDK-21737

          http://bugs.adobe.com/jira/browse/SDK-23559

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/projects/framework/src/mx/binding/utils/ChangeWatcher.as

          flex/sdk/trunk/modules/antTasks/src/flex/ant/AsDocTask.java

          flex/sdk/trunk/modules/antTasks/src/flex/ant/CompcTask.java

          flex/sdk/trunk/modules/antTasks/src/flex/ant/MxmlcTask.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/Source.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/InterfaceCompiler.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocument.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/init/ValueInitializer.ja va

          flex/sdk/trunk/modules/swfutils/src/java/flash/util/StringUtils.java