0 Replies Latest reply on Oct 29, 2009 8:23 AM by Paul Reilly

    [svn:fx-trunk] 11255: * Another batch of compiler fixes.

    Paul Reilly Level 1

      Revision: 11255

      Author:   preilly@adobe.com

      Date:     2009-10-29 08:23:33 -0700 (Thu, 29 Oct 2009)

       

      Log Message:

      ***********

      • Another batch of compiler fixes.

       

      QE notes:

      Doc notes:

      Bugs: SDK-23354, SDK-22804, SDK-22995, SDK-23561, SDK-23466

      Reviewer: Corey

      Tests run: full cyclone

      Is noteworthy for integration: Yes, The CSS PropertyReference()

                                     function only allows document property

                                     references now.

      Code-level description of changes:

       

        modules/compiler/src/java/flex2/compiler_en.properties

       

          Added css.StyleDef.InvalidPropertyReference and

          css.StyleDef.PropertyReferenceRequiresDocument.

       

        modules/compiler/src/java/flex2/compiler/as3/managed/ManagedFirstPassEvaluator.java

       

          Modified evaluate(Context, FunctionDefinitionNode) to check that

          the param type is String for uid setters.  This fixes SDK-23354.

       

        modules/compiler/src/java/flex2/compiler/as3/As3Compiler.java

       

          Modified transferDependencies() to filter out bogus ReferenceValue

          names that occur when imports are missing.  This fixes SDK-22804.

       

        modules/compiler/src/java/flex2/compiler/css/StyleDef.java

       

          Modified processReference() to only allow PropertyReference() to

          reference document properties.  This fixes SDK-22995.

       

        modules/compiler/src/java/flex2/compiler/mxml/InterfaceGenerator.java

       

          Modified generateInstanceVariables() to generate a line number

          mapped position for the TypeExpressionNode.  This fixes SDK-23561.

       

        modules/compiler/src/java/flex2/compiler/mxml/gen/ClassDefLib.vm

       

          Modified emitBindingsSetup macro to generate a not null check for

          the destination function when the type is Array.  This fixes

          SDK-23466.

       

        modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

       

          Modified generateSourceFunctionArrayConversion() to do the

          equivalent of the ClassDefLib.vm change.

       

        modules/compiler/src/java/flex2/compiler/util/MultiName.java

       

          Added assert for localName's to ensure they don't have a dot in

          them.  This should help us catch problems like SDK-22804 closer to

          the source.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-23354

          http://bugs.adobe.com/jira/browse/SDK-22804

          http://bugs.adobe.com/jira/browse/SDK-22995

          http://bugs.adobe.com/jira/browse/SDK-23561

          http://bugs.adobe.com/jira/browse/SDK-23466

          http://bugs.adobe.com/jira/browse/SDK-23354

          http://bugs.adobe.com/jira/browse/SDK-22804

          http://bugs.adobe.com/jira/browse/SDK-22995

          http://bugs.adobe.com/jira/browse/SDK-23561

          http://bugs.adobe.com/jira/browse/SDK-23466

          http://bugs.adobe.com/jira/browse/SDK-22804

       

      Modified Paths:

      **************

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/As3Compiler.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/managed/ManagedFirstPassEvalu ator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/css/StyleDef.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/InterfaceGenerator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/gen/ClassDefLib.vm

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/util/MultiName.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler_en.properties