0 Replies Latest reply on Nov 12, 2009 1:18 PM by Paul Reilly

    [svn:fx-trunk] 11732: * Another batch of compiler fixes.

    Paul Reilly Level 1

      Revision: 11732

      Author:   preilly@adobe.com

      Date:     2009-11-12 13:18:47 -0800 (Thu, 12 Nov 2009)

       

      Log Message:

      ***********

      • Another batch of compiler fixes.

       

      QE notes: The mxunit test

                Namespaces_LibraryTag_Definition_GraphicalAssetTest failed,

                but I think the test should result in a compile error.

      Doc notes:

      Bugs: SDK-23898, SDK-24001, SDK-24075, SDK-22471, SDK-23772, SDK-23662

      Reviewer: Corey

      Tests run: ran full cyclone twice, but all the mustella tests timed

                 out on the "cyclone assist" server, so I ran a sampling

                 locally.

      Is noteworthy for integration: No

      Code-level description of changes:

       

        modules/swfutils/src/java/flash/util/StringUtils.java

       

          Modified unformatString() to more closely match the opposite of

          formatString() by only converting a double backslash to a single

          backslash when it precedes a 'u'.  This fixes SDK-23898.

       

        modules/compiler/src/java/flex2/compiler/common/CompilerConfiguration.java

       

          Made report-invalid-styles-as-warnings and

          show-invalid-css-property-warnings no longer hidden.  This fixes

          SDK-24001.

       

        modules/compiler/src/java/flex2/compiler/SymbolTable.java

       

          Added debug param to constructor and modified it to turn on

          perCompileData.omitTrace when it's false.  This fixes SDK-24075.

       

        modules/compiler/src/java/flex2/compiler/mxml/rep/AtEmbed.java

       

          Uncommented fix for SDK-22471, which was accidentally commented

          out.

       

        modules/compiler/src/java/flex2/compiler/mxml/InterfaceCompiler.java

       

          Modified analyze(XMLNode) to only add an import for XMLUtil when

          e4x is false.  This fixes SDK-23772.

       

          Modified analyze(XMLListNode) to no longer add an import for

          XMLUtil, because it's not used.

       

          Modified createInlineComponentUnit() and createDefinitionUnit() to

          use new method getInnerClassName() to create a unique className,

          if the user doesn't specify one.  This fixes SDK-23662.

       

      Ticket Links:

      ************

          http://bugs.adobe.com/jira/browse/SDK-23898

          http://bugs.adobe.com/jira/browse/SDK-24001

          http://bugs.adobe.com/jira/browse/SDK-24075

          http://bugs.adobe.com/jira/browse/SDK-22471

          http://bugs.adobe.com/jira/browse/SDK-23772

          http://bugs.adobe.com/jira/browse/SDK-23662

          http://bugs.adobe.com/jira/browse/SDK-23898

          http://bugs.adobe.com/jira/browse/SDK-24001

          http://bugs.adobe.com/jira/browse/SDK-24075

          http://bugs.adobe.com/jira/browse/SDK-22471

          http://bugs.adobe.com/jira/browse/SDK-23772

          http://bugs.adobe.com/jira/browse/SDK-23662

       

      Modified Paths:

      **************

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/SymbolTable.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/common/CompilerConfiguration.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/InterfaceCompiler.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/rep/AtEmbed.java

          flex/sdk/trunk/modules/swfutils/src/java/flash/util/StringUtils.java