0 Replies Latest reply on Nov 20, 2009 8:01 AM by Paul Reilly

    [svn:fx-trunk] 12043: * Weekly batch of compiler fixes.

    Paul Reilly Level 1

      Revision: 12043

      Revision: 12043

      Author:   preilly@adobe.com

      Date:     2009-11-20 08:00:57 -0800 (Fri, 20 Nov 2009)

      Log Message:

      ***********

      • Weekly batch of compiler fixes.

       

      QE notes: mustella server runs can use -debug or

                -omit-trace-statements=false now.

      Doc notes: Yes, new option.

      Bugs: SDK-24229, SDK-24228, SDK-24224, SDK-24271, SDK-24001, SDK-24075

      Reviewer: Pete F (SwcChecksums.java, PreLink.java), Corey (everything else)

      Tests run: full cyclone, which had some mxunit and junit failures,

                 which I fixed and confirmed by rerunning the failed tests.

                 Mustella had a bunch of VideoPlayer related failures, which

                 I assume a related to the switch to the OSMF player.

      Is noteworthy for integration: Yes, added new option -omit-trace-statements,

                                     the default is true for production.

      Code-level description of changes:

       

        modules/compiler/src/java/flex2/configuration_en.properties

       

          Added details for report-invalid-styles-as-warnings and

          show-invalid-css-property-warnings to finish off SDK-24001.

       

        modules/compiler/src/java/flex2/tools/SwcChecksums.java

       

          Take non-SWC theme files into consideration when generating the

          SWC checksum, because getThemeInfo() in CompilerConfiguration has

          doChecksum() returning false.  This fixes part of SDK-24271.

       

        modules/compiler/src/java/flex2/tools/PreLink.java

       

          Modified processMainUnit() to replace duplicates returned from

          StylesContainer.processDependencies() rather than skipping them.

          This fixes the rest of SDK-24271, which was introduced by revision

          11575.

       

        modules/compiler/src/java/flex2/compiler/common/CompilerConfiguration.java

       

          Added omit-trace-statements option.

       

        modules/compiler/src/java/flex2/compiler/common/DefaultsConfigurator.java

        frameworks/flex-config.xml

       

          Added omit-trace-statements default of true.

       

        modules/compiler/src/java/flex2/compiler/SymbolTable.java

       

          Modified constructor to turn on trace statement omission when

          debug is false and omitTraceStatements is true.

       

        modules/compiler/src/java/flex2/compiler/mxml/InterfaceCompiler.java

       

          Essentially revert the fix for SDK-23662, which fixes SDK-24229,

          SDK-24228, and SDK-24224.

       

      Ticket Links:

      ***********

          http://bugs.adobe.com/jira/browse/SDK-24229

          http://bugs.adobe.com/jira/browse/SDK-24228

          http://bugs.adobe.com/jira/browse/SDK-24224

          http://bugs.adobe.com/jira/browse/SDK-24271

          http://bugs.adobe.com/jira/browse/SDK-24001

          http://bugs.adobe.com/jira/browse/SDK-24075

          http://bugs.adobe.com/jira/browse/SDK-24001

          http://bugs.adobe.com/jira/browse/SDK-24271

          http://bugs.adobe.com/jira/browse/SDK-24271

          http://bugs.adobe.com/jira/browse/SDK-23662

          http://bugs.adobe.com/jira/browse/SDK-24229

          http://bugs.adobe.com/jira/browse/SDK-24228

          http://bugs.adobe.com/jira/browse/SDK-24224

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/flex-config.xml

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/SymbolTable.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/common/CompilerConfiguration.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/common/DefaultsConfigurator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/InterfaceCompiler.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/configuration_en.properties

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/Mxmlc.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/PreLink.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/SwcChecksums.java