0 Replies Latest reply on Nov 30, 2009 1:25 PM by Paul Reilly

    [svn:fx-trunk] 12294: * Fix for error reporting bug.

    Paul Reilly Level 1

      Revision: 12294

      Revision: 12294

      Author:   preilly@adobe.com

      Date:     2009-11-30 13:25:28 -0800 (Mon, 30 Nov 2009)

      Log Message:

      ***********

      • Fix for error reporting bug.  The bug was caused by a warning being

        reported during one compilation and then an error being reported in

        a following compilation.  Due to the warning, the Source's logger

        was disconnected instead of being nulled out during the first

        compilation.  Then in the second compilation, we weren't reassigning

        the logger, so the disconnected logger was being left in place.  As

        a result, it was throwing off expected error counts and caused an

        assert to fire.

       

      QE notes: There is probably an easier way to reproduce the assertion

                that George hit without having to create multiple projects

                and without having to manually copy SWC's around.  I didn't

                realize this until I had a fix, though.  One key aspect that

                George didn't note and might not have realized, is that the

                variable needs to cause a warning, so leaving off a

                namespace works, but making it public, private, etc doesn't.

      Doc notes:

      Bugs: SDK-24314

      Reviewer: Corey

      Tests run: checkintests

      Is noteworthy for integration: fixes FB issue

      Code-level description of changes:

       

        Modified setLogger() to always reassign logger.

       

      Ticket Links:

      ***********

          http://bugs.adobe.com/jira/browse/SDK-24314

       

      Modified Paths:

      **************

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/Source.java