0 Replies Latest reply on Dec 7, 2009 7:01 AM by Paul Reilly

    [svn:fx-trunk] 12603: * Another weekly batch of compiler fixes.

    Paul Reilly Level 1

      Revision: 12603

      Revision: 12603

      Author:   preilly@adobe.com

      Date:     2009-12-07 07:00:47 -0800 (Mon, 07 Dec 2009)

      Log Message:

      ***********

      • Another weekly batch of compiler fixes.

       

      QE notes: JUnit oem.ApplicationTest#testReadOnlySwf should no longer

                expect an exception to be thrown.

      Doc notes:

      Bugs: SDK-23890, SDK-24517, SDK-24466, SDK-24232, SDK-24405

      Reviewer: Corey

      Cycloner: "cyclone assist"

      Tests run: full cyclone

      Is noteworthy for integration: yes, OEM Compiler API should no longer

                                     throw exceptions.

      Code-level description of changes:

       

        modules/compiler/src/java/flex2/tools/oem/Application.java

       

          Added catch alls to build() and link().  This is part of the fix

          for SDK-23890.

       

        modules/compiler/src/java/flex2/tools/oem/Library.java

       

          Added catch alls to compile() and link().  This is part of the fix

          for SDK-23890.

       

          Wrapped printStackTrace() calls in a Trace.error check.

       

        modules/compiler/src/java/flex2/tools/oem/Toolkit.java

        modules/compiler/src/java/flex2/tools/Compc.java

        modules/compiler/src/java/flex2/tools/DigestTool.java

        modules/compiler/src/java/flex2/tools/SwcDependencies.java

        modules/compiler/src/java/flex2/tools/Optimizer.java

        modules/compiler/src/java/flex2/tools/Mxmlc.java

        modules/compiler/src/java/flex2/tools/Fcsh.java

        modules/compiler/src/java/flex2/tools/ASDoc.java

        modules/compiler/src/java/flex2/compiler/css/CssCompiler.java

       

          Wrapped printStackTrace() calls in a Trace.error check.   

       

        modules/compiler/src/java/flex2/tools/PreLink.java

       

          Modified processMainUnit() to locate and load default styles each

          time through, because new dependencies can cause new SWC's,

          potentially with defaults.css files, to become "used".  This fixes

          SDK-24517.

       

        modules/compiler/src/java/flex2/compiler/as3/genext/GenerativeSecondPassEvaluator.java

       

          Modified generateSupportCode() As3Compiler.cleanNodeFactory() so

          that the NodeFactory compound_names from one document don't spill

          over into another one.  This fixes SDK-24466.

       

        modules/compiler/src/java/flex2/compiler/as3/As3Compiler.java

       

          Added assert to parse2() to help catch places where we parse

          without calling cleanNodeFactory().

       

        modules/compiler/src/java/flex2/compiler/SymbolTable.java

       

          Added some comments to document some newly discovered FlashBuilder

          entrypoints.

       

        modules/compiler/src/java/flex2/compiler/mxml/Grammar.jj

       

          Moved guts of parseApplication() into new

          parseApplicationComponent() and modified parseInlineComponent()

          and parseDefinition() to use parseApplicationComponent() instead

          of parseUIComponent().  This fixes SDK-24232.

       

        modules/compiler/src/java/flex2/compiler/mxml/gen/ClassDefLib.vm

       

          Modified Binding source function to use "result == null" instead

          of "!result" when doing Array singleton coercion.  This fixes

          SDK-24405.

       

        modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

       

          Direct AST generation equivalent of ClassDefLib.vm change.

       

      Ticket Links:

      ***********

          http://bugs.adobe.com/jira/browse/SDK-23890

          http://bugs.adobe.com/jira/browse/SDK-24517

          http://bugs.adobe.com/jira/browse/SDK-24466

          http://bugs.adobe.com/jira/browse/SDK-24232

          http://bugs.adobe.com/jira/browse/SDK-24405

          http://bugs.adobe.com/jira/browse/SDK-23890

          http://bugs.adobe.com/jira/browse/SDK-23890

          http://bugs.adobe.com/jira/browse/SDK-24517

          http://bugs.adobe.com/jira/browse/SDK-24466

          http://bugs.adobe.com/jira/browse/SDK-24232

          http://bugs.adobe.com/jira/browse/SDK-24405

       

      Modified Paths:

      **************

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/SymbolTable.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/As3Compiler.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/genext/GenerativeSecondPassEv aluator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/css/CssCompiler.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/Grammar.jj

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/mxml/gen/ClassDefLib.vm

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/ASDoc.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/Compc.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/DigestTool.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/Fcsh.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/Mxmlc.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/Optimizer.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/PreLink.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/SwcDependencies.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/oem/Application.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/oem/Library.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/oem/Toolkit.java