0 Replies Latest reply on Dec 22, 2009 2:40 PM by Paul Reilly

    [svn:fx-trunk] 13169: * Fixes for two FB issues and two regressions caused by recent fixes.

    Paul Reilly Level 1

      Revision: 13169

      Revision: 13169

      Author:   preilly@adobe.com

      Date:     2009-12-22 14:39:59 -0800 (Tue, 22 Dec 2009)

      Log Message:

      ***********

      • Fixes for two FB issues and two regressions caused by recent fixes.

       

      QE notes:

      Doc notes:

      Bugs: SDK-24708, SDK-24668, SDK-24827, SDK-24829

      Reviewer: Corey

      Tests run: checkintests, com.adobe.flexbuilder.project JUnit tests

      Is noteworthy for integration: Yes, fixes two FB issues

      Code-level description of changes:

       

        modules/compiler/src/java/flex2/tools/oem/Library.java

        modules/compiler/src/java/flex2/tools/Compc.java

        modules/compiler/src/java/flex2/tools/Fcsh.java

        modules/compiler/src/java/flex2/compiler/asdoc/AsDocAPI.java

       

          Modified calls into SwcAPI's setupClasses() and

          setupNamespaceComponents() to pass in the SourceList.

       

        modules/compiler/src/java/flex2/tools/VersionInfo.java

       

          Added null check to getBuild().

       

        modules/compiler/src/java/flex2/compiler/CompilerAPI.java

       

          Modified compile() to only add elements of "classes" to "sources"

          if not already contained.  This covers the case of a Source being

          in the SourceList and the manifest.

       

        modules/compiler/src/java/flex2/compiler/swc/SwcAPI.java

       

          Modified setupClasses() and setupNamespaceComponents() to check the

          SourceList before the SourcePath when looking up sources.

       

        modules/compiler/src/java/flex2/compiler/SourceList.java

       

          Made getPaths() public.

       

        modules/compiler/src/java/flex2/compiler/CompilationUnit.java

       

          Modified setState() to skip disconnecting the root's Logger.  This

          fixes SDK-24827 and SDK-24829.

       

        modules/compiler/src/java/flex2/tools/oem/internal/OEMReport.java

       

          Added sourceList variable, modified procressSources() to

          initialize it, and modified init() to recursively store a

          timestamp for each path in the SourceList.  This fixes SDK-24708.

       

      Ticket Links:

      ***********

          http://bugs.adobe.com/jira/browse/SDK-24708

          http://bugs.adobe.com/jira/browse/SDK-24668

          http://bugs.adobe.com/jira/browse/SDK-24827

          http://bugs.adobe.com/jira/browse/SDK-24829

          http://bugs.adobe.com/jira/browse/SDK-24827

          http://bugs.adobe.com/jira/browse/SDK-24829

          http://bugs.adobe.com/jira/browse/SDK-24708

       

      Modified Paths:

      **************

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/CompilationUnit.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/CompilerAPI.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/SourceList.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/as3/SignatureExtension.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/asdoc/AsDocAPI.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/compiler/swc/SwcAPI.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/Compc.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/Fcsh.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/VersionInfo.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/oem/Library.java

          flex/sdk/trunk/modules/compiler/src/java/flex2/tools/oem/internal/OEMReport.java