0 Replies Latest reply on Mar 23, 2010 11:45 AM by Jason Szeto

    [svn:fx-4.x] 14946: ColorPicker and PopUpButton mirroring bug fix

    Jason Szeto Level 3

      Revision: 14946

      Revision: 14946

      Author:   jszeto@adobe.com

      Date:     2010-03-23 11:45:37 -0700 (Tue, 23 Mar 2010)

      Log Message:

      ***********

      ColorPicker and PopUpButton mirroring bug fix

       

      http://bugs.adobe.com/jira/browse/SDK-25916 - color/label field in swatch panel isn't updated when layoutDirection is

      changed between rtl and ltr

       

      Since the ColorPicker's SwatchPanel is parented by the SystemManager it wasn't inheriting the layoutDirection and it wasn't invalidating the layoutDirection. The fix is to pass the layoutDirection to the SwatchPanel and always call invalidateLayoutDirection in PopUpManager.addPopUp.

       

      http://bugs.adobe.com/jira/browse/SDK-25828 - initial popup starts with wrong position, not aligned with PopupButton when there is padding set on container

       

      The popup is not guaranteed to know its size until it has been added as a popup. Moved the position logic to after the popup has been added.

       

       

      QE notes: test mirrored ColorPicker and PopUpButton

      Doc notes: none

      Bugs: SDK-25916

      Reviewer: Carol

      Tests run: checkintests, ColorPicker, PopUpButton

      Is noteworthy for integration: no

       

      Ticket Links:

      ***********

          http://bugs.adobe.com/jira/browse/SDK-25916

          http://bugs.adobe.com/jira/browse/SDK-25828

          http://bugs.adobe.com/jira/browse/SDK-25916

       

      Modified Paths:

      **************

          flex/sdk/branches/4.x/frameworks/projects/framework/src/mx/controls/ColorPicker.as

          flex/sdk/branches/4.x/frameworks/projects/framework/src/mx/controls/PopUpButton.as

          flex/sdk/branches/4.x/frameworks/projects/framework/src/mx/managers/PopUpManagerImpl.as