2 Replies Latest reply on Apr 4, 2010 11:58 PM by John Waller

    Is this CSS OK?

    DeonH Level 1

      Hi there.

       

      Can someone who knows CSS better than me, just double check if this is OK? I just want to make sure that there are nothing that works against one another or duplication.

       

      http://www.josua.co.za/css/josua-css.css

       

      Thank you very much so long.

       

      Regards,

      Deon

        • 1. Re: Is this CSS OK?
          John Waller Adobe Community Professional & MVP

          Seems OK apart from this rule:

           

          #footer p {
          size: 120px;
          color: #FFFFFF; /* donker pers */
          padding: 5px 0px;

          }

           

          should be

           

          #footer p {
          font-size: 120px;
          color: #FFFFFF; /* donker pers */
          padding: 5px 0px;
          }

           

          120px is huge. Should it be 12px? or 120%?

          • 2. Re: Is this CSS OK?
            DeonH Level 1

            Hi John and thanx for the reply.

             

            Yes, it should have been 120%. Thanx for showing me that.

             

            In my process of learning CSS, I try not to make use of pre-written CSS layouts but rather hand code myself, and here I made a terrible mistake.

             

            Than again.

            Deon