0 Replies Latest reply on May 26, 2010 5:20 PM by Jason Szeto

    [svn:fx-trunk] 16331: Form Bug Fixes

    Jason Szeto Level 3

      Revision: 16331

      Revision: 16331

      Author:   jszeto@adobe.com

      Date:     2010-05-26 17:20:51 -0700 (Wed, 26 May 2010)

      Log Message:

      ***********

      Form Bug Fixes

       

      SDK-26517 - Form should take into account includeInLayout property when calculating baselineElementPosition

       

      Added logic into Group to find the first element that has includeInLayout == true.

       

      SDK-26509 - Spark Form shows dual error strings in non-stacked layout

       

      Removed error string from FormSkin. Created a StackedFormSKin skin which includes the error string.

       

      SDK-26499 - Spark Form skin should use errorStringDisplay skin part instead of errorStringText

       

      Changed name to errorTextDisplay

       

      SDK-26498 - Spark Form needs more padding around error strings

       

      Added padding to the entire Form

       

      SDK-26503 - Difficult to create custom Spark FormItem skin due to embedded required/error icon assets

       

      Added new requiredIndicatorSource and errorIndicatorSource styles to FormItem. FormItem skins now grab the icons from these styles. Custom skin also have access to these icons.

       

      QE notes: Form layout has changed

      Doc notes: none

      Bugs: SDK-26517, SDK-26509, SDK-26499, SDK-26498, SDK-26503

      Reviewer: Kevin

      Tests run: checkintests

      Is noteworthy for integration: no

       

      Ticket Links:

      ***********

          http://bugs.adobe.com/jira/browse/SDK-26517

          http://bugs.adobe.com/jira/browse/SDK-26509

          http://bugs.adobe.com/jira/browse/SDK-26499

          http://bugs.adobe.com/jira/browse/SDK-26498

          http://bugs.adobe.com/jira/browse/SDK-26503

          http://bugs.adobe.com/jira/browse/SDK-26517

          http://bugs.adobe.com/jira/browse/SDK-26509

          http://bugs.adobe.com/jira/browse/SDK-26499

          http://bugs.adobe.com/jira/browse/SDK-26498

          http://bugs.adobe.com/jira/browse/SDK-26503

       

      Modified Paths:

      **************

          flex/sdk/trunk/frameworks/build_framework.xml

          flex/sdk/trunk/frameworks/projects/spark/build.xml

          flex/sdk/trunk/frameworks/projects/spark/defaults.css

          flex/sdk/trunk/frameworks/projects/spark/src/SparkClasses.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/FormItem.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/components/Group.as

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/FormHeadingSkin.mxml

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/FormItemSkin.mxml

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/FormSkin.mxml

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/StackedFormHeadingSkin.mxm l

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/StackedFormItemSkin.mxml

          flex/sdk/trunk/frameworks/tests/basicTests/spark/scripts/FormTestScript.mxml

       

      Added Paths:

      ***********

          flex/sdk/trunk/frameworks/projects/spark/assets/

          flex/sdk/trunk/frameworks/projects/spark/assets/ErrorIndicator.png

          flex/sdk/trunk/frameworks/projects/spark/assets/RequiredIndicator.png

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/StackedFormSkin.mxml

       

      Removed Paths:

      *************

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/assets/ErrorIndicator.png

          flex/sdk/trunk/frameworks/projects/spark/src/spark/skins/spark/assets/RequiredIndicator.p ng