8 Replies Latest reply on Feb 9, 2011 2:59 AM by mahendra rajeshirke

    please review my site

    mahendra rajeshirke Level 2

      hi guys,

       

      i have created a html5 site www pestocon com

       

      i want your opinion of sites look in order to site's design, color combination, usability

       

      thx in advance

       

        • 1. Re: please review my site
          BenPleysier Adobe Community Professional & MVP

          The site does not validate, see here http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fwww.pestocon.com%2F

           

          What is this?

          <meta charset="UTF-8">
          <meta http-equiv="content-type" content="text/html; charset=UTF-8" />

          The type attribute is obsolete and what is the 'space + /' at the end of the line?

          <link href="images/favicon.ico" rel="shortcut icon" type="image/x-icon" />
          <link rel="stylesheet" href="css/reset.css" type="text/css" media="all" />
          <link rel="stylesheet" href="css/layout.css" type="text/css" media="all" />
          <link rel="stylesheet" href="css/style.css" type="text/css" media="all" />
          <script src="js/gen_validatorv31.js" type="text/javascript"></script>
          <script src="js/jquery-1.js" type="text/javascript"></script>
          <script src="js/jquery.js" type="text/javascript"></script>
          <script src="js/blogger.js" type="text/javascript"></script>
          <script src="js/cufon-replace.js" type="text/javascript"></script>
          <script src="js/Baskerville-Bold_500.js" type="text/javascript"></script>

          <script type="text/javascript" src="js/imagepreloader.js"></script>
          <script type="text/javascript">

          Why place this in the body tag?

          <script type="text/javascript" src="js/wz_tooltip.js"></script>

          Why have a wrapper called main when you could use html and body as wrappers?

           

          Why all the divs? Have a look at this small portion of the markup.

          <div class="main">
              <div class="row-top clear">
                <div class="fright"><a href="index.php">Home</a> | <a href="faq.php">FAQ</a> | <a href="site_map.php">Site map</a></div>
                  <div class="fleft"><a onMouseOut="UnTip()" onMouseOver="Tip('Demand for pest control services has been increasing over the past years. Indian in general are more aware of their health and hygiene in their working and living environment. Indian are beginning to realize that pest living in their environment can bring along many types of diseases to human beings. For Frequently Ask Questions  <a href=faq.php>click here<\/a>', WIDTH, 500,  SHADOW, true, STICKY, 1, CLOSEBTN, true, CLICKCLOSE, true,BGCOLOR, '#FFFFFF', TITLE, 'Why Do You Need Pest Control')" href="javascript:void(0);">Why Do You Need Pest Control ?</a></div>

              </div>
          </div>
          <div class="tail-content">
              <div class="tail-content-top">
                  <div class="main border_main">
                      <!--==============================header=================================-->
                      <header>
                         <div class="header-box clear">
                              <div class="header-right"><img src="images/pic01.jpg" alt="pest control" width="160" height="180">
                                 <div class="header-text"><div class="blockquote">

                                    <blockquote><A href="#">Hi</A>, Our vacate cleans consist of a comprehensive and competitive range of services! We can add and remove services on request enabling us to better suit your needs and budget.
                                    </blockquote></div><span class="link4">- Company Proprietor</span>
          </div>
                              </div>
                              <a href="http://www.pestocon.com" class="logo" title="starlight design"><img src="images/logo.png" alt="logo" width="242" height="70" class="png"></a>
                          </div>
                          <div class="header-nav clear">
                              <div class="clear bottom-border">

          What I mean with the above is if you want to place a link to the right don't use a div but do so by

          <a class="fright" href="index.php">

          Always use existing elements for styling and use a div only where there is no other choice

           

          As you can see, I am not a designer, hence the absence of comments on styling. My forte is web development especially with regard to keeping it simple.

           

          Please regard my comments as friendly food for thought, there are better ways that, in parallel, allow easier access for search engine bots.

           

          The first priority is to have an html5 site.

          1 person found this helpful
          • 2. Re: please review my site
            mahendra rajeshirke Level 2

            well ty for suggestions. i am also waiting for graphic design review of site.

            • 3. Re: please review my site
              terminalblock

              anyone want to review my site about terminal blocks? i'm not sure if it's in html5 or not.. thanks in advance

              • 5. Re: please review my site
                terminalblock Level 1

                thanks dude! looks like it's not  haha

                 

                Date: Fri, 4 Feb 2011 19:30:36 -0700

                From: forums@adobe.com

                To: screwterminalblock@hotmail.com

                Subject: please review my site

                 

                This will tell you http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fscrewterminalblock.com%2F

                 

                Gramps

                >

                • 6. Re: please review my site
                  mahendra rajeshirke Level 2

                  Thnx mr.altruistic gramps i think i got my answer

                  • 7. Re: please review my site
                    phreaddee123 Level 2

                    come on man are we stupid?

                    by definition your very first line should be your doctype declaration

                    ie.

                    <!doctype html> if you want HTML5

                    or

                    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

                    if you want XHTML 1.0 Transitional

                     

                    If someone sold me an apple and I wanted an orange I would not be happy. same goes with people passing off their websites as HTML5 when they are not.

                     

                    besides the fact that technically you could just change your doctype and it would be HTML5. it just flys in the face of the whole premise of why HTML5 was created.and there are no new HTML5 elements in there to differentiate it anyway. but you would have known that the whole time you were building it, because if you were using HTML5 you'd probably be using tags like <header> <nav> <section> <article><aside> etc etc, you would probably at least be looking at <audio> or <video> you'd know too because you'd have to put in a javascript hack to get it to work in "non HTML5" browsers.

                     

                    now onto the critique of your XHTML 1.0 Transitional website.

                    you have perhaps taken a bit of a leap towards css3 which is promising, but overall the site is in need of some work and the colours just are bad, real bad.

                     

                    go here

                    http://kuler.adobe.com/#create/fromacolor

                    and pick a nice colour set.

                     

                    tidy your code

                    look at some "modern" design

                     

                    rebuild it in HTML5

                    then ask for a critique.

                    1 person found this helpful
                    • 8. Re: please review my site
                      mahendra rajeshirke Level 2

                      phreaddee123 wrote:

                       

                      come on man are we stupid?


                      Hi,

                       

                       

                      thnx for suggestions, this site is now being developed by other people. i left my prev job. so working on another fdfd  site, which will be soon  propagated and declared in this forum.

                       

                      By the way the code was used in pestocon com was really bad and the color scheme is also bad.